Re: Small suggested change

[Jason Moore]

Mark,

Thanks for the note. Are you familiar with submitting pull requests to Github? If so, that is the ideal way to help make this change.

Jason

moorepants.info
+01 530-601-9791

On Thu, Jan 18, 2018 at 3:33 PM, Mark Yeatman <mark.x....@gmail.com> wrote:

Hello, 

First off, want to say that I'm really glad this package exists, especially the cython/c codegen functionality. 

Second, I'm not sure this is the best place to suggest code changes, but I have zero experience working on open source projects like PyDy, so I'm putting it here. 

In the "pydy\codegen\matrix_generator.py" on line 56 on the git hub page, we have:

    required_args.remove(me.dynamicsymbols._t)

I think this should be changed to 

    required_args.discard(me.dynamicsymbols._t)

Which doesn't throw an error if that symbol doesn't exist in the input matrix. 

Thanks

--
You received this message because you are subscribed to the Google Groups "PyDy" group.
To unsubscribe from this group and stop receiving emails from it, send an email to pydy+unsubscribe@googlegroups.com.
To post to this group, send email to py...@googlegroups.com.
Visit this group at https://groups.google.com/group/pydy.
For more options, visit https://groups.google.com/d/optout.

[Mark Yeatman]

I'll give it a shot. 

On Saturday, January 20, 2018 at 4:51:49 PM UTC-6, moorepants wrote:

Mark,

Thanks for the note. Are you familiar with submitting pull requests to Github? If so, that is the ideal way to help make this change.

Jason

moorepants.info
+01 530-601-9791

On Thu, Jan 18, 2018 at 3:33 PM, Mark Yeatman <mark.x....@gmail.com> wrote:

Hello, 

First off, want to say that I'm really glad this package exists, especially the cython/c codegen functionality. 

Second, I'm not sure this is the best place to suggest code changes, but I have zero experience working on open source projects like PyDy, so I'm putting it here. 

In the "pydy\codegen\matrix_generator.py" on line 56 on the git hub page, we have:

    required_args.remove(me.dynamicsymbols._t)

I think this should be changed to 

    required_args.discard(me.dynamicsymbols._t)

Which doesn't throw an error if that symbol doesn't exist in the input matrix. 

Thanks

--
You received this message because you are subscribed to the Google Groups "PyDy" group.

To unsubscribe from this group and stop receiving emails from it, send an email to pydy+uns...@googlegroups.com.

[Jason Moore]

Thanks. Let us know if you need help.

Jason

moorepants.info
+01 530-601-9791

To unsubscribe from this group and stop receiving emails from it, send an email to pydy+unsubscribe@googlegroups.com.