[PATCH] [Issue #287] Confirm box will be hidden by the window dialog

9 views
Skip to first unread message

Xin Ding

unread,
Dec 17, 2013, 10:20:22 PM12/17/13
to project...@googlegroups.com, Xin Ding
Signed-off-by: Xin Ding <xin...@linux.vnet.ibm.com>
---
ui/js/src/kimchi.window.js | 12 ------------
1 file changed, 12 deletions(-)

diff --git a/ui/js/src/kimchi.window.js b/ui/js/src/kimchi.window.js
index 2212b5b..5cf8054 100644
--- a/ui/js/src/kimchi.window.js
+++ b/ui/js/src/kimchi.window.js
@@ -26,18 +26,6 @@ kimchi.window = (function() {
url: settings
};

- if (_windows.length) {
- var lastZIndex = parseInt($('#' + _windows[_windows.length - 1]).css('zIndex'));
- if (settings['style']) {
- settings['style']['zIndex'] = lastZIndex + 1;
- }
- else {
- settings['style'] = {
- zIndex: lastZIndex + 1
- };
- }
- }
-
var windowID = settings['id'] || 'window-' + _windows.length;

if ($('#' + windowID).length) {
--
1.8.3.2

Hongliang Wang

unread,
Dec 18, 2013, 12:22:25 AM12/18/13
to project...@googlegroups.com
On 12/18/2013 11:20 AM, Xin Ding wrote:
> Signed-off-by: Xin Ding <xin...@linux.vnet.ibm.com>
Reviewed-by: Hongliang Wang <hlw...@linux.vnet.ibm.com>

Passed use cases on Chrome:

1. Create Guest
1.1. Remove all templates
1.2. Open Guest Tab
1.3. Click Add Button (+)
1.4. Click Add Template Button
1.5. Select local iso
1.6. Click Search more iso Button
1.7. Confirm box is right there on top of all windows

2. Consider Situation when User not Logged in
2.1. Open Host Tab
2.2. Click Shutdown Button and see a confirm box pop up
2.3. Log out by entering kimchi.logout(); in developer's tool console
2.4. Log-in window is right there on top of the confirm box

Aline Manera

unread,
Dec 18, 2013, 7:25:08 AM12/18/13
to Xin Ding, project...@googlegroups.com, Xin Ding
Applied. Thanks.

Regards,

Aline Manera

Reply all
Reply to author
Forward
0 new messages