Timelines or estimates for processing pull requests

16 views
Skip to first unread message

konstantin...@teamdev.com

unread,
Dec 27, 2017, 4:39:06 AM12/27/17
to Polymer
Hi! I'm very interested in changes provided by #185 PR in `paper-checkbox` element (https://github.com/PolymerElements/paper-checkbox/pull/185). Is there any information about how long can it take to review specified PR? Should I wait or is it better to create custom component with required functionality? Thanks in advance!

Daniel Llewellyn

unread,
Dec 27, 2017, 1:26:36 PM12/27/17
to konstantin...@teamdev.com, Polymer
On 27 December 2017 at 09:39, <konstantin...@teamdev.com> wrote:
Hi! I'm very interested in changes provided by #185 PR in `paper-checkbox` element (https://github.com/PolymerElements/paper-checkbox/pull/185). Is there any information about how long can it take to review specified PR? Should I wait or is it better to create custom component with required functionality? Thanks in advance!

​The paper- elements are supposed to implement the Material Design as specified by Google: https://github.com/material-components and https://material.io​. They are opinionated by intent and design. Unless you provide a detail/reasoned rationale as to why the visual design should be changed then your PR is unlikely to be included. Especially if the changes aren't included in the Material Design specification first.

Also, it is the western holiday season right now due to the religious festival celebrated by Christian adherents; a lot of companies are closed, so the Google employees in control of the paper-checkbox repository are likely to not be working until the new year.

--
Daniel Llewellyn
Bowl Hat
​​
Reply all
Reply to author
Forward
0 new messages