Box.set(el) should remove element from its parent

8 views
Skip to first unread message

guille.r...@gmail.com

unread,
May 10, 2018, 7:29:52 AM5/10/18
to PlayN
Hi all,

I came across a problem when moving elements around (from one container to another) and traced it down to Box.set().

Adding al element to other containers will automatically remove the element from their previous parent. Not so with Box. The problem can be reproduced with the following sequence:

box1.set(foo);
box2.set(foo);
box1.set(bar);

I have submitted a PR which fixes this (https://github.com/threerings/tripleplay/pull/70)

Best,

Guillermo

Michael Bayne

unread,
May 10, 2018, 10:26:29 AM5/10/18
to pl...@googlegroups.com
Merged, thanks!

--

---
You received this message because you are subscribed to the Google Groups "PlayN" group.
To unsubscribe from this group and stop receiving emails from it, send an email to playn+un...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
Reply all
Reply to author
Forward
0 new messages