GlobalSettings injection in 2.4

213 views
Skip to first unread message

benmccann

unread,
Apr 25, 2015, 1:18:57 PM4/25/15
to play-fram...@googlegroups.com
Hi,

I'm trying to migrate Connectifier to Play 2.4.  It looks like GlobalSettings isn't being injected and so I got fairly stuck.  In play 2.3, the Injector was created inside GlobalSettings and so you could use it to get an instance of whatever object you needed. Assuming I'm right that it's not currently being injected, is that something we could change before the next RC?

Thanks,
Ben

Ben McCann

unread,
Apr 25, 2015, 1:43:57 PM4/25/15
to play-fram...@googlegroups.com
Found where this is being done and it's not being injected:

Still not sure how to fix it though...



--
You received this message because you are subscribed to the Google Groups "Play framework dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to play-framework-...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.



--
about.me/benmccann

Ben McCann

unread,
Apr 25, 2015, 2:37:44 PM4/25/15
to play-fram...@googlegroups.com
Ahh, we're binding to an instance here:

We should bind to a class instead of an instance and then the injector can handle the instance creation

--
about.me/benmccann

Rich Dougherty

unread,
Apr 25, 2015, 4:46:23 PM4/25/15
to Ben McCann, play-fram...@googlegroups.com, Mirco Dotta
I'm not sure if this would help you but Mirco has been working on docs for migrating GlobalSettings.


We should probably get this merged.
Rich Dougherty
Engineer, Typesafe, Inc

Ben McCann

unread,
Apr 25, 2015, 10:33:15 PM4/25/15
to Rich Dougherty, play-fram...@googlegroups.com, Mirco Dotta
Yeah, that might help quite a bit. Thanks for sharing!

Should we mark GlobalSettings as deprecated? Or possibly remove it?


-Ben

Reply all
Reply to author
Forward
0 new messages