Problem with migration of play-java-ebean-example to 2.6.0

[Grzegorz Słowikowski]

Hi Devs

Can you check
https://github.com/playframework/play-java-ebean-example/pull/45?
It seems that some backward incompatible has been introduced in Twirl
1.3.1 (Play! 2.6.0-RC2 uses Twirl 1.3.0, Play! 2.6.0 uses Twirl 1.3.2).

One template doesn't compile and the question is, can it be fixed or is
it a critical bug in Twirl.

Regards
Grzegorz Slowikowski

[Grzegorz Slowikowski]

The same problem here:
https://github.com/playframework/play-scala-anorm-example/pull/54

[Marcos Pereira]

Grzegorz,

Thank you very much for the report. This was caused by a regression in Twirl and here is the fix:

https://github.com/playframework/twirl/pull/140

Good thing is that twirl has its own release cycle and we can release a new version as soon the fix above is integrated.

Again, thank you so much for the feedback.

Best.

--
You received this message because you are subscribed to the Google Groups "Play Framework" group.
To unsubscribe from this group and stop receiving emails from it, send an email to play-framework+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/play-framework/93bc5496-d2e2-4efc-953d-d6237dc4231d%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

Marcos Pereira

Software Engineer, Lightbend.com

[Greg Methvin]

I just released twirl 1.3.3 with the fix, but my recommendation in general would be to avoid using the "@if(foo) bar" and instead use "@if(foo) { bar }". I actually did not realize the "single line" syntax existed in twirl, and I think it's a bit confusing if used on the same line as an HTML tag like that. We decided to update the templates to use braces on the if, so we don't need to override the twirl version.

--
You received this message because you are subscribed to the Google Groups "Play framework dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to play-framework-dev+unsub...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

Greg Methvin

Tech Lead - Play Framework

Lightbend, Inc.