Netty 4

[benmccann]

Would there be any objections if I take a stab at getting Play upgraded to Netty 4?

-Ben

[Rich Dougherty]

Hi Ben

Were you thinking of upgrading for Play 2.4? If so we'd probably want to get it in reasonably quickly because (I think) we're nearing the end of 2.4. James can probably comment on this.

We've put off upgrading Netty for a while now because we're intending to change to Akka HTTP in a future release, probably the next release after Play 2.4. That doesn't mean there wouldn't be a benefit to upgrading to Netty for Play 2.4. You just might want to bear in mind that Netty 4 might only be used for a single release.

If you do upgrade Netty then we'll also want to be careful about performance regressions. It looks like Netty 4 could be faster than Netty 3 so hopefully we'll actually see improvements instead of regressions! If you have a branch that you want to benchmark then let me know and I can run some tests on our performance testing machine.

Cheers

Rich

On Fri, Mar 27, 2015 at 7:19 AM, benmccann <benjamin...@gmail.com> wrote:

Would there be any objections if I take a stab at getting Play upgraded to Netty 4?

-Ben

--
You received this message because you are subscribed to the Google Groups "Play framework dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to play-framework-...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

Rich Dougherty

Engineer, Typesafe, Inc

@richdougherty

[Ben McCann]

Yeah, I was a bit curious when the first 2.4 RC was going to be released. If there's 2 weeks or so left, then I may take a shot at it.

In the meantime, I've tried to upgrade to 3.10.1.Final in PR 4137. I'm really confused because it's failing Jenkins, but passing on my machine. Is the build acting strangely? I've sent another PR that's getting the same problem.

I've seen some of the Akka work going in, but haven't followed along too closely. Akka isn't meant to be used in 2.4 is it?  It could be nice to have one release where both are present to ensure folks can switch back and forth in case they find any unforseen problems.

-Ben

--

about.me/benmccann

[James RopR]

Sorry Ben, the build failure is likely my fault, I merged some very old PRs yesterday and it looks like one of them broke the build. I'll fix in a few hours unless you want to take a look before then.

[Ben McCann]

Ah, thanks. I thought it was something on my machine for awhile. I'll let you take a look since I'm pretty slammed today.

Thanks James!

about.me/benmccann

[Rich Dougherty]

On Fri, Mar 27, 2015 at 8:34 AM, Ben McCann <b...@benmccann.com> wrote:

Yeah, I was a bit curious when the first 2.4 RC was going to be released. If there's 2 weeks or so left, then I may take a shot at it.

You should have 2 weeks, but James will be able to confirm. 

I've seen some of the Akka work going in, but haven't followed along too closely. Akka isn't meant to be used in 2.4 is it?  It could be nice to have one release where both are present to ensure folks can switch back and forth in case they find any unforseen problems.

The Akka HTTP backend will be experimental in Play 2.4. We want to make Akka HTTP the default backend in the release after 2.4. I'm not sure whether we are planning on keeping a Netty backend. I guess it will come down to on our confidence in the new Akka HTTP backend vs the extra effort to maintain two backends. At this stage it is probably too early to tell.

[James RopR]

Hi Ben,

I was hoping to release an RC very soon... I don't know how much effort it will be to upgrade to Netty 4, if it's simple, go ahead.

Cheers,

James

--

You received this message because you are subscribed to the Google Groups "Play framework dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to play-framework-...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

James RopR
Software Engineer

Typesafe – Build reactive apps!
Twitter: @jroper

[Ben McCann]

Actually, I take it back. I'm not going to try. I have a PR out to upgrade us to 3.10, which might be interesting, but I'm going to stop there.  I realized my reason for wanting to upgrade to Netty 4 didn't make sense.  In case anyone wants to try later for 3.0, it looks like upgrading netty-http-pipelining would be the main challenge

I took a stab at fixing the build error. If there's a better way to do it feel free to close and submit another fix instead

-Ben

about.me/benmccann

[Megazord]

Ben,

Upgrade to Netty 4 is not a simple task. Besides the play code itself, both netty-http-pipelining and async-http-client also requires upgrades (and maybe some parts of Akka?). I thought about doing that last week, but since Akka HTTP will be the main backend, I don't think the efforts pays off.

Anyway, If you want to do that and needs help, just let me know because I'm also interested about Netty.

Bests,

On Thursday, March 26, 2015 at 8:49:58 PM UTC-3, benmccann wrote:

Actually, I take it back. I'm not going to try. I have a PR out to upgrade us to 3.10, which might be interesting, but I'm going to stop there.  I realized my reason for wanting to upgrade to Netty 4 didn't make sense.  In case anyone wants to try later for 3.0, it looks like upgrading netty-http-pipelining would be the main challenge

I took a stab at fixing the build error. If there's a better way to do it feel free to close and submit another fix instead

-Ben

On Thu, Mar 26, 2015 at 4:18 PM, James RopR <ja...@typesafe.com> wrote:

Hi Ben,

I was hoping to release an RC very soon... I don't know how much effort it will be to upgrade to Netty 4, if it's simple, go ahead.

Cheers,

James

On 27 March 2015 at 07:29, Rich Dougherty <ri...@rd.gen.nz> wrote:

On Fri, Mar 27, 2015 at 8:34 AM, Ben McCann <b...@benmccann.com> wrote:

Yeah, I was a bit curious when the first 2.4 RC was going to be released. If there's 2 weeks or so left, then I may take a shot at it.

You should have 2 weeks, but James will be able to confirm. 

I've seen some of the Akka work going in, but haven't followed along too closely. Akka isn't meant to be used in 2.4 is it?  It could be nice to have one release where both are present to ensure folks can switch back and forth in case they find any unforseen problems.

The Akka HTTP backend will be experimental in Play 2.4. We want to make Akka HTTP the default backend in the release after 2.4. I'm not sure whether we are planning on keeping a Netty backend. I guess it will come down to on our confidence in the new Akka HTTP backend vs the extra effort to maintain two backends. At this stage it is probably too early to tell.

--
You received this message because you are subscribed to the Google Groups "Play framework dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to play-framework-dev+unsub...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

James RopR
Software Engineer

Typesafe – Build reactive apps!
Twitter: @jroper

--
You received this message because you are subscribed to the Google Groups "Play framework dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to play-framework-dev+unsub...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

about.me/benmccann

[Ben McCann]

Yeah, definitely netty-http-pipelining will be harder than the core play code. Thanks for pointing out async-http-client as well as I hadn't looked at it.

I was originally wanting to upgrade to Netty 4 because I have some other dependencies I'd like to start using that use Netty 4 and I was worried about the version conflict. Turns out that the changed the package name between Netty 3 and Netty 4, so that's not going to be an issue at all. Now that I've realized we won't have any problem with it, I don't really have a reason to upgrade to Netty 4 anymore. Netty 3 is working just fine, so I can't afford the time to upgrade given that there's not going to be any real benefit for us.

-Ben

To unsubscribe from this group and stop receiving emails from it, send an email to play-framework-...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

about.me/benmccann