use_html5_inputs? vs html5?

14 views
Skip to first unread message

Kai Schneider

unread,
Apr 17, 2014, 12:42:43 PM4/17/14
to plataformate...@googlegroups.com
Hey Guys,

in https://github.com/plataformatec/simple_form/blob/master/lib/simple_form/inputs/date_time_input.rb#L7 you use use_html5_inputs? to check if a html5 input should be created whereas in for example numeric_input.rb and others you use html5? for that check. use_html5_inputs? comes back nil even if b.use :html5 is set in the initializer. What is the reason for not using html5? here? 

Thanks for the create gem btw. :)
Kai

Vasiliy Ermolovich

unread,
Apr 17, 2014, 1:11:05 PM4/17/14
to plataformate...@googlegroups.com
Hey, you can find the answer here - https://github.com/plataformatec/simple_form/pull/935

Kai Schneider wrote:
you use /use_html5_inputs? /to check if a html5 input should be
created whereas in for example /numeric_input.rb/ and others you use
/html5?/ for that check. /use_html5_inputs? /comes back /nil/ even if
/b.use :html5/ is set in the initializer. What is the reason for not
using /html5?/ here?


Thanks for the create gem btw. :)
Kai

--
You received this message because you are subscribed to the Google
Groups "SimpleForm" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to plataformatec-simp...@googlegroups.com
<mailto:plataformatec-simp...@googlegroups.com>.
For more options, visit https://groups.google.com/d/optout.

Kai Schneider

unread,
Apr 18, 2014, 7:40:13 AM4/18/14
to plataformate...@googlegroups.com
Thank you!


On Thursday, April 17, 2014 7:11:05 PM UTC+2, Vasiliy Ermolovich wrote:
Hey, you can find the answer here - https://github.com/plataformatec/simple_form/pull/935

Kai Schneider wrote:

Hey Guys,

in
https://github.com/plataformatec/simple_form/blob/master/lib/simple_form/inputs/date_time_input.rb#L7
you use /use_html5_inputs? /to check if a html5 input should be
created whereas in for example /numeric_input.rb/ and others you use
/html5?/ for that check. /use_html5_inputs? /comes back /nil/ even if
/b.use :html5/ is set in the initializer. What is the reason for not
using /html5?/ here?

Thanks for the create gem btw. :)
Kai

--
You received this message because you are subscribed to the Google
Groups "SimpleForm" group.
To unsubscribe from this group and stop receiving emails from it, send
Reply all
Reply to author
Forward
0 new messages