Nullable getBody() for MessageInterface

[Dracony]

I can think of a lot of usecases with empty body, e.g. redirecting a user, processing a HEAD request, etc. For these cases it makes sense that the getBody method in MessageInterface is nulllable. Otherwise it forces some empty implementation to be done.

[Anton Titov]

Hi,

why not just use stream with empty body?

[Roman Tsjupa]

Well yes, that's the whole point. You cant just pass an empty string and be done with it, it has to be a StreamableInterface intaance. It doesnt seem elegant to create an empty one just for that purpose

--
You received this message because you are subscribed to a topic in the Google Groups "PHP Framework Interoperability Group" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/php-fig/c7amaAhnZbg/unsubscribe.
To unsubscribe from this group and all its topics, send an email to php-fig+u...@googlegroups.com.
To post to this group, send email to php...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/981974d6-19e4-4425-9728-701551229d76%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Michael Dowling]

You can create the stream lazily on first access, so there is practically no overhead.

You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+u...@googlegroups.com.

To post to this group, send email to php...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/CANamvv13CABFGgrboNxP5wHeZg%2BwR1_%3DC-fJawUtfMAeciXV-Q%40mail.gmail.com.

[Evert Pot]

On 2015-04-20 9:55 PM, Roman Tsjupa wrote:
> Well yes, that's the whole point. You cant just pass an empty string and
> be done with it, it has to be a StreamableInterface intaance. It doesnt
> seem elegant to create an empty one just for that purpose

You'll find that the opposite is true when you actually use the
interface. By making it optional, you basically force anyone to first
check if they received null, and only then do operations on the body.

This adds a lot of additional if statements for people using these, and
that's just so save the hassle of removing 1 object.

Evert

[Roman Tsjupa]

Its not really about overhead or some optimization. I just like the idea of being able to use withBody(null).

Also allowing nullable geyBody turns it to an optional parameter. So insteaf of passing 'new StringStream('')' I could just use null.

To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/45FC7F6D-96F5-49E3-84A2-4125DB006C61%40gmail.com.

[Roman Tsjupa]

Well yes the null check is a downside, although in a lot of cases when reading a message a (string) cast will be used anyway:

echo (string) $response->getBody();

In this case null works perfectly

--
You received this message because you are subscribed to a topic in the Google Groups "PHP Framework Interoperability Group" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/php-fig/c7amaAhnZbg/unsubscribe.
To unsubscribe from this group and all its topics, send an email to php-fig+u...@googlegroups.com.
To post to this group, send email to php...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/5535AF82.1070509%40gmail.com.

[Roman Tsjupa]

That would fix nothing since StringStream('') would still be there just in a different place

On Apr 21, 2015 4:10 AM, "Anton Titov" <wolf...@gmail.com> wrote:

You can write your specific implementation which converts null argument to empty stream inside, this will keep getBody() behavior consistent.

To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/f977eb1d-51b5-4420-a111-81e75dda9509%40googlegroups.com.

[Korvin Szanto]

I think it's clear that there is no "fix" needed here, I would argue that the null conditional is plenty to decide against this.

To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/CANamvv360T1vWC%3DWgzLjM7u75Qzph9t2t6KKNUHyrHi_u8bAvQ%40mail.gmail.com.

[Roman Tsjupa]

Ah, well, lets leave it at that then. Its not that huge of a deal anyeway and the conditional argument does make sense

To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/CANeXGWWxzGz7OUJhLvrKzOkANhYkKWCiqu59QJ%3DwwvDgORBa6Q%40mail.gmail.com.

[Bernhard Schussek]

I don't think that's a good change. Returning a NullStream instance seems much better to me.

--

Bernhard Schussek
Blog: http://webmozarts.com
Twitter: http://twitter.com/webmozart

To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/CANamvv3feCWNOBpStoiTfP7Pb5s60-3Go-k2FG_VV%2B%3Ds_%2Bm%2BFA%40mail.gmail.com.