Disabling issues on Github

196 views
Skip to first unread message

Michael Cullum

unread,
Nov 22, 2015, 3:28:47 PM11/22/15
to PHP Framework Interoperability Group
Hi all,

Are there any objections to disabling issues on github? At the moment almost every ticket on there is someone asking that a change be made to a PSR or things that should be being discussed on the mailing list.

Unless I'm mistaken they've not been used for the active development of any PSRs but if any editors choose in the future to use GH issues for their PSR development they can always do something similar to https://github.com/cs-extended/fig-standards/issues?utf8=%E2%9C%93&q=is%3Aissue

Many thanks,
Michael C

Alexander Makarov

unread,
Nov 22, 2015, 3:34:30 PM11/22/15
to PHP Framework Interoperability Group
Issues are used for active discussion on phpdoc and coding standards. They could be closed to force discussions on mailing list but with prior review i.e. corresponding editors should get through all open issues and close the ones that could not be implemented (standard accepted) or do not make sense. The ones that make sense should be implemented.

Closing everything at once w/o checking these isn't an option.

Cal Evans

unread,
Nov 22, 2015, 3:49:41 PM11/22/15
to php...@googlegroups.com
I agree with Michael that all discussions should be forced to the mailing list.

Cheers!
=C=

--
You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+u...@googlegroups.com.
To post to this group, send email to php...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/84e8c263-8ec2-4f0e-b90e-bf59b30003fe%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.



--
How to find, hire, and retain developers

Mike van Riel

unread,
Nov 22, 2015, 3:56:58 PM11/22/15
to php...@googlegroups.com
It is beneficial to the process to gather as much opinions as possible; at the same time members have indicated in the past that not too many discussions should be had here and that those should be moved to a working group (other mailing list or similar location). 

To be honest: I am getting confused now; do we want all discussions on this mailing list or not?

Cal Evans

unread,
Nov 22, 2015, 3:59:52 PM11/22/15
to php...@googlegroups.com
As much of a pain as it is, having a single repository for all discussions means that there is a single archive. Closing the issues would force the discussions here.

Cheers!
=C=


For more options, visit https://groups.google.com/d/optout.

Robert Hafner

unread,
Nov 22, 2015, 4:02:24 PM11/22/15
to php...@googlegroups.com

I don’t like the idea of disabling issues. I do like the idea of writing an appropriate contribution guide pushing big discussions to the list and quickly shutting down anything that breaks it, but I don’t want to raise the barrier for people to submit things like formatting or spelling corrections (which does happen quite a bit).

Rob



Paul M. Jones

unread,
Nov 22, 2015, 4:18:30 PM11/22/15
to php...@googlegroups.com

> On Nov 22, 2015, at 15:02, Robert Hafner <ted...@tedivm.com> wrote:
>
> I don’t want to raise the barrier for people to submit things like formatting or spelling corrections (which does happen quite a bit).

Does turning off "issues" also turn off "pull requests"? If not, then PRs for formatting and spelling corrections remain.


--
Paul M. Jones
pmjo...@gmail.com
http://paul-m-jones.com

Modernizing Legacy Applications in PHP
https://leanpub.com/mlaphp

Solving the N+1 Problem in PHP
https://leanpub.com/sn1php


Paul M. Jones

unread,
Nov 22, 2015, 4:23:45 PM11/22/15
to php...@googlegroups.com

> On Nov 22, 2015, at 15:18, Paul M. Jones <pmjo...@gmail.com> wrote:
>
>
>> On Nov 22, 2015, at 15:02, Robert Hafner <ted...@tedivm.com> wrote:
>>
>> I don’t want to raise the barrier for people to submit things like formatting or spelling corrections (which does happen quite a bit).
>
> Does turning off "issues" also turn off "pull requests"? If not, then PRs for formatting and spelling corrections remain.

I just tried it on a repo of my own; turning off "issues" *does not* turn off PRs. So if submitting corrections is the only issue (heh) then PRs would still be available.

Korvin Szanto

unread,
Nov 22, 2015, 4:25:50 PM11/22/15
to php...@googlegroups.com
I support disabling issues and moving all discussion to the mailing list. I have a very hard time figuring out where discussions are happening most of the time and I think more eyes on issues is a healthy thing for us.

--
You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+u...@googlegroups.com.
To post to this group, send email to php...@googlegroups.com.

Michael Cullum

unread,
Nov 22, 2015, 6:23:08 PM11/22/15
to PHP Framework Interoperability Group
Alexander,

I've been through basically all of them (All the CS ones at least) and they are old requests for changes to PSR-2. A few have been implemented in PSR-12, a few I don't intend to include in PSR-12 (e.g. HTML indentation), and one which is on my todo list. But again, if they want to discuss adding those things to PSR-12/PSR-5 they are welcome to do so by creating a mailing list topic for discussing it (which is exactly what we want them to be doing). Also I'd add that I don't have access to close issues and I'm not sure Mike does either which makes the process rather tedious.

--
Thanks,
Michael

Alexander Makarov

unread,
Nov 23, 2015, 5:48:17 AM11/23/15
to PHP Framework Interoperability Group
Comment there and I'll close them.

Michael Cullum

unread,
Nov 23, 2015, 11:25:24 AM11/23/15
to PHP FIG

My point being, is that nessasary if its agreed to switch the system off anyway (as consensus appears to be)?

--
Thanks,
Michael Cullum

--
You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+u...@googlegroups.com.
To post to this group, send email to php...@googlegroups.com.

Brian Retterer

unread,
Nov 23, 2015, 12:20:11 PM11/23/15
to PHP Framework Interoperability Group
+1 for turning off issues.  Too many locations for comments causes a lot of confusion of what happened first... where is the comment flow... and so on.

Andreas Hennings (donquixote)

unread,
Mar 19, 2016, 1:59:01 PM3/19/16
to PHP Framework Interoperability Group
It seems that issues on github have indeed been disabled. I understand why.

But now, old discussions are no longer available. E.g. https://github.com/php-fig/fig-standards/issues/525#event-547655305

This is bad, because these discussions contain some valuable arguments. I just wanted to show this discussion to someone else, and found that it was gone.
Is there a way to have the old stuff read-only?

Michael Cullum

unread,
Mar 19, 2016, 3:05:29 PM3/19/16
to PHP FIG

Unfortunately not but I'm happy to enable it temporarily for people to grab copies of issues? Or if someone could make a script to scrap them and generate texts files with them in a put them in a repo?

Reply all
Reply to author
Forward
0 new messages