[PSR-15][REVIEW] Last call!

61 views
Skip to first unread message

Matthew Weier O'Phinney

unread,
Jan 9, 2018, 3:22:39 PM1/9/18
to php...@googlegroups.com
Hi, everyone!

We're still in the review period for PSR-15 at this time, discussing
some lingering clarifications. If you have not had a chance to review
the proposal at this time, and it interests you for any reason, we
strongly urge you to review it at this time and provide us any
feedback ASAP (even if that's as simple as "looks fine").

- Spec: https://github.com/php-fig/fig-standards/blob/58b25b75a5768468369c86617e52ecf40d5c5154/proposed/http-handlers/request-handlers.md
- Meta document:
https://github.com/php-fig/fig-standards/blob/58b25b75a5768468369c86617e52ecf40d5c5154/proposed/http-handlers/request-handlers-meta.md

We are debating one last pull request, which provides a number of
examples for middleware and request handler authors, as well as those
who might be designing dispatch systems:

- https://github.com/php-fig/fig-standards/pull/996

Some specific questions we're interested in:

- We are targeting primarily authors of middleware and handlers, and
secondarily those who define dispatch systems. As a middleware or
handler author, would you be able to take the spec and build
something? Would you understand how the interfaces interact with one
another?

--
Matthew Weier O'Phinney
mweiero...@gmail.com
https://mwop.net/

Benjamin Mack

unread,
Jan 10, 2018, 5:06:34 PM1/10/18
to php...@googlegroups.com
Hey Matthew,

speaking for the TYPO3 CMS project, we have a similar approach for the request handlers already, and PSR-15 would almost fit in (although we have named "handle()" into "handleRequest()" which is irrelevant in this discussion IMHO, as it's about "naming things") and we'd surely adapt it.

As for the double-pass / single-pass discussion, single-pass would be the only solution for us to use - thus, this is good for us to go (although we don't have voting power, but should not matter).

The only thing I personally thought on first reading a couple of weeks ago was that PSR-15 does not ship with a base exception which could be extended from (see 1.4 Handling Exceptions), but that discussion happened as well already.

So: "Looks fine" from my side, go for it!

All the best,
Benni Mack.
> --
> You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+u...@googlegroups.com.
> To post to this group, send email to php...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/CAJp_myVFw%2B0a7tfFi9RTgtzNGTWmvyjZjC1s%2B7v_M%2BoaXDPkag%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.

Matthew Weier O'Phinney

unread,
Jan 10, 2018, 5:32:19 PM1/10/18
to php...@googlegroups.com
On Wed, Jan 10, 2018 at 4:06 PM, Benjamin Mack <benjam...@gmail.com> wrote:
> speaking for the TYPO3 CMS project, we have a similar approach for the request handlers already, and PSR-15 would almost fit in (although we have named "handle()" into "handleRequest()" which is irrelevant in this discussion IMHO, as it's about "naming things") and we'd surely adapt it.
>
> As for the double-pass / single-pass discussion, single-pass would be the only solution for us to use - thus, this is good for us to go (although we don't have voting power, but should not matter).
>
> The only thing I personally thought on first reading a couple of weeks ago was that PSR-15 does not ship with a base exception which could be extended from (see 1.4 Handling Exceptions), but that discussion happened as well already.

For those who did not read the discussion: The rationale is because we
do not want to force developers to wrap all code internal to the
middleware/handler in a try/catch block in order to throw a
spec-defined exception type. We felt this was limiting, and ultimately
would likely prevent adoption, particularly as several in the working
group have successfully developed exception-handling middleware that
was capable of working with any exception/throwable.

Thanks for your feedback, Benni Mack!
> To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/063F6C1A-1454-4C4E-9A58-546EAD42E714%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.



Reply all
Reply to author
Forward
0 new messages