PSR-12: Order of сonstants, methods and properties definitions

[Кирилл Фрейман]

Hi everyone!

In PHP de-facto exists some best practice of ordering methods and properties. 
It seems to me that this order is most common:

Constants

    public const

    protected const

    private const

Properties

    public static properties

    public properties

    protected static properties

    protected properties

    private static properties

    private properties

Methods

    magic methods

    public static methods

    public methods

    protected static methods

    protected methods

    private static methods

    private methods

Should we standartize it? 

[Alessandro Lai]

I agree that a sequence of constants-properties-methods is ok and expected. But apart of requiring the constructor as the first declared method, I'm against a "MUST" keyword for the remaining stuff. We can maybe suggest and ordering of this kind, but for the most part the order shouldn't be this important, and I think also that the flow of execution between methods has some importance in the order between them; I think that also "Clean Code" suggests something like "keeping near a called method".

[Andreas Möller]

Should we standartize it? 

How about enforcing on a per-project-basis with https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/master/src/Fixer/ClassNotation/OrderedClassElementsFixer.php?

Best regards,

Andreas

[Alexander Makarov]

Putting publicly visible properties before private ones is something new to me.

[Stefano Torresi]

I don't think this detail is worth standardising, ordering is very situational and can bear a lot of different semantics.
We can surely leave this to common user conventions.

--
You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+u...@googlegroups.com.
To post to this group, send email to php...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/211769db-61a6-4fb4-85fd-60c3508f78ac%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Larry Garfield]

I am also fine with leaving this unspecified.  There's too many cases where I want to group things "logically", in a contextually-dependent way.

At best I could see "constants, then properties, then methods", but that's as far as I think it's reasonable to go and I'd be fine with not even doing that much.

--Larry Garfield

To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/CAFojS1s1vNEX3pfEU1rY%2Bc72feduU%2B_03SZpFD1XsD9n8Kd-Pg%40mail.gmail.com.

[Woody Gilk]

I've taken to defining private properties at the end of the class, especially if the constructor is private.

This is not something that should be standardized, IMO.

To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/611d0c4a-6e1d-9b59-bc9d-78e9ebc9000c%40garfieldtech.com.

For more options, visit https://groups.google.com/d/optout.

--

Woody Gilk

http://about.me/shadowhand

[Cees-Jan Kiewiet]

Tbh I don't think we shouldn't specify class element order that deep. Different class designs call for different ordering IMHO.

To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+unsubscribe@googlegroups.com.

To post to this group, send email to php...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/211769db-61a6-4fb4-85fd-60c3508f78ac%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group.

To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+unsubscribe@googlegroups.com.

To post to this group, send email to php...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/CAFojS1s1vNEX3pfEU1rY%2Bc72feduU%2B_03SZpFD1XsD9n8Kd-Pg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group.

To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+unsubscribe@googlegroups.com.

To post to this group, send email to php...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/611d0c4a-6e1d-9b59-bc9d-78e9ebc9000c%40garfieldtech.com.
For more options, visit https://groups.google.com/d/optout.

--

Woody Gilk

http://about.me/shadowhand

--

You received this message because you are subscribed to the Google Groups "PHP Framework Interoperability Group" group.

To unsubscribe from this group and stop receiving emails from it, send an email to php-fig+unsubscribe@googlegroups.com.

To post to this group, send email to php...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/php-fig/CAGOJM6J8eVkNsak1YpuCHVyfr-HKMSs2uWdM6HSiWEtpvYXDqg%40mail.gmail.com.