PhantomJS 1.8 countdown

[Ariya Hidayat]

Folks,

It's only 2 weeks to the intended release time for version 1.8, which
BTW will be called "Blue Winter Rose" (as named by Ivan), see
http://phantomjs.org/release-names.html. There are still few minor
features to be merged but overall it seems to be pretty complete.

The release notes would still need to be populated:
http://phantomjs.org/release-1.8.html. If you want to contribute, it's
just a simple HTML file in the gh-pages branch of our repository. Look
at some past release notes (e.g.
http://phantomjs.org/release-1.7.html). if you need more examples.
Pull requests to make it more complete is always welcomed!

Also, since I've been asked too often about this: bleeding-edge
WebKit. I originally thought of updating our WebKit in this release.
However, with the merge of GhostDriver (as our WebDriver
implementation), I will postpone it to 1.9. That way, this release can
serve as a good platform for WebDriver.


Thank you!

Regards,

--
Ariya Hidayat, http://ariya.ofilabs.com
http://twitter.com/ariyahidayat

[Jon Leighton]

On 08/12/12 05:36, Ariya Hidayat wrote:
> Also, since I've been asked too often about this: bleeding-edge
> WebKit. I originally thought of updating our WebKit in this release.
> However, with the merge of GhostDriver (as our WebDriver
> implementation), I will postpone it to 1.9. That way, this release can
> serve as a good platform for WebDriver.

Would it be feasible to update to the latest point release of Qt 4.8 in
this release? (4.8.4) Looking at the release notes, 4.8.3 contained a
webkit bugfix release, and I am kinda curious about whether this will
solve some of the crashes people have. (In particular, LOTS of
Poltergeist users report crashes with TTF fonts on OS X.)

I'm happy to help if you can point me in the right direction. (Unless it
will take lots of time, which I unfortunately don't have loads of at the
moment.)

I'd also like to make a patch to support adding multiple files to <input
type="file" multiple>, as Capybara now requires this of drivers. Will
try to send a PR in the next few days.

Cheers,
Jon

--
http://jonathanleighton.com/

[Ivan De Marino]

2 cents: unless of major API changes, I'd be OK to work on "tuning" GhostDriver (and related PhantomJS bits) to work with latest 4.8.4.

There is a remote chance that could break our WebDriver (not that I know of - just being devil's advocate here), but nothing should put us off.

Myself I'd look forward to some of the fixes Jon mentioned, in the chance they reduce the number of crashes (that GhostDriver users are indeed facing).

What do you think Ariya?

--
You received this message because you are subscribed to the Google Groups "phantomjs" group.
Visit this group at http://groups.google.com/group/phantomjs?hl=en.

--

Ivan De Marino

Coder, Technologist, Cook, Italian

blog.ivandemarino.me | www.linkedin.com/in/ivandemarino | twitter.com/detronizator

[Joshua Boyd]

As you prepare for the 1.8 release, I built
4c285c419da176d4f303c08e761a2d10ef58f824 (at the time of writing the
latest commit to phantomjs) on Ubuntu 12.04 i686 and ran the tests and
saw the following failures:

WebPage object should open url using secure connection


WebServer object should handle post requests ('Content-Type' =
'application/x-www-form-urlencoded')



WebServer object should handle post requests ('Content-Type' = 'ANY')

I stuck the build and test log in a gist:
https://gist.github.com/4259487

I don't have complete tests results for AMD64 at moment, but I will try
to resolve that soon.

[Ariya Hidayat]

> Would it be feasible to update to the latest point release of Qt 4.8 in
> this release? (4.8.4) Looking at the release notes, 4.8.3 contained a
> webkit bugfix release, and I am kinda curious about whether this will
> solve some of the crashes people have. (In particular, LOTS of
> Poltergeist users report crashes with TTF fonts on OS X.)
>
> I'm happy to help if you can point me in the right direction. (Unless it
> will take lots of time, which I unfortunately don't have loads of at the
> moment.)

The best way to this is to take a diff between Qt 4.8.2 and 4.8.4 and
try to apply it to our own copy.

[Jon Leighton]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/12/12 06:25, Ariya Hidayat wrote:
>> Would it be feasible to update to the latest point release of Qt
>> 4.8 in this release? (4.8.4) Looking at the release notes, 4.8.3
>> contained a webkit bugfix release, and I am kinda curious about
>> whether this will solve some of the crashes people have. (In
>> particular, LOTS of Poltergeist users report crashes with TTF
>> fonts on OS X.)
>>
>> I'm happy to help if you can point me in the right direction.
>> (Unless it will take lots of time, which I unfortunately don't
>> have loads of at the moment.)
>
> The best way to this is to take a diff between Qt 4.8.2 and 4.8.4
> and try to apply it to our own copy.

Right, I had a go last night at importing 4.8.4 and then applying our
patches back on top, but that sounds like a better way as it'll
preserve "git blame". I'll try that.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iQEcBAEBAgAGBQJQyEf8AAoJEIeyJN+tUcliJZ4H/RCH3lb0jSU3EOp8SJpMTzET
uyC+2DeHSP5UbUj1ZlLRqdekLeLDH3/S79VsNESbdN/oYVI8WAoEhkiQ2yCcPxk0
Zq4lh8+rw9fguEx4wOX2gBEMwY24XdXEZ17d3z4S0ERNANQtMD2vuQUwtdYLCg+s
xXemUNaajbeg65f84CqVEtCutdT6sWHxnBCprBWD7Jd4GnddAcw2xS3ULCMuPf/F
UAatYmdqEl/KB6w924XTMgDOjakuH5qJ7fh+8VAwSFVJd4QuNwWxh/ii9BabReTm
W8w6BLb9NJULY+QnC2e9OQpuGH1t7GfwyIrOpdqQqtPT5k/Tf6HYUtTbyEv0Erk=
=A5FE
-----END PGP SIGNATURE-----

[Ivan De Marino]

You rock Jon!
Let us know how it goes.

Also, at the end let us know if you think this is something we could script-out.
-----
Ivan De Marino
Coder, Cook, Cyclist, Gamer

Sent while standing on one leg

[Jon Leighton]

On 12/12/12 09:42, Ivan De Marino wrote:
> You rock Jon!
> Let us know how it goes.
>
> Also, at the end let us know if you think this is something we could script-out.

Here we go: https://github.com/ariya/phantomjs/pull/367

It seems to work fine for me on Linux. Please test on OS X if possible.

[James Greene]

Niiiiiice!  I should be able to test it out on Windows tonight as well.

~~James

[Andrew Ray]

I don't see any mention of stability fixes in this release. phantomjs seems pretty unstable in its current state. are there any commits specifically for stability / crashing?

[James Greene]

Andrew:
Please cite pertinent issues that are causing you stability problems rather than throwing out vague blanket statements.
~~James

On Dec 14, 2012 7:31 PM, "Andrew Ray" <delva...@gmail.com> wrote:

I don't see any mention of stability fixes in this release. phantomjs seems pretty unstable in its current state. are there any commits specifically for stability / crashing?

--

[Ariya Hidayat]

I assume these crashes are font related? I think there have been
multiple reports about it, including in the issue tracker.

[Andrew Ray]

I would love to debug and submit crash reports and cite pertinent issues but it currently seems impossible and no one wants to tell me how to do it? http://code.google.com/p/phantomjs/issues/detail?id=885&sort=-id https://groups.google.com/forum/?fromgroups=#!topic/phantomjs/5NEgbVOWOMI 

[Ivan De Marino]

GhostDriver 1.0.1 is ready to be merged: https://github.com/ariya/phantomjs/pull/372

I don't plan to do any more work/fixes before 1.8, so this is the last PR of this year for me :)

Happy Holidays seems appropriate!

[James Greene]

Andrew:
I just responded to both your Issue and Discussion Thread. Please check them out. Thanks!
~~James

[Ivan De Marino]

Unfortunately there is a typo in GhostDriver 1.0.1.

It's a tiny stupid typo, but I need to push a new PR to you :(

--
You received this message because you are subscribed to the Google Groups "phantomjs" group.
Visit this group at http://groups.google.com/group/phantomjs?hl=en.

--

[Ivan De Marino]

There you go: https://github.com/ariya/phantomjs/pull/373

[Ariya Hidayat]

I've prepared and push 1.8 branch. Testing this on various operating
systems, as well as checking it against other project's test sets
(CasperJS, Poltergeist, etc) would be appreciated!

Thank you.

Regards,


--
Ariya Hidayat, http://ariya.ofilabs.com
http://twitter.com/ariyahidayat

http://gplus.to/ariyahidayat

[Nicolas Perriault]

On Wed, Dec 19, 2012 at 4:37 AM, Ariya Hidayat <ariya....@gmail.com> wrote:

> I've prepared and push 1.8 branch. Testing this on various operating
> systems, as well as checking it against other project's test sets
> (CasperJS, Poltergeist, etc) would be appreciated!

Gonna compile it and give you feedback ASAP :)

Thanks

--
Nicolas Perriault
https://nicolas.perriault.net/
Phone: +33 (0) 660 92 08 67

[Nicolas Perriault]

On Wed, Dec 19, 2012 at 11:27 AM, Nicolas Perriault
<nic...@perriault.net> wrote:

> Gonna compile it and give you feedback ASAP :)

Done. All CasperJS tests pass in ~50s against this version , nearly
the same time as with 1.7.

Ready to ship for me!

++

[James Greene]

Building for Windows 7 now.

~~James

[James Greene]

Windows 7 results:

 - Compiled fine

 - 21 more specs than 1.7

 - 3 more spec failures (1.7 had ~9, 1.8 has ~12... most to do with HTTP timeouts)

 - Spec runtime went waaaay up: 1.7 was 2.9s, 1.8 is 16.4s (~5.7x longer)

Sincerely,
    James Greene

[James Greene]

Let me know if you want me to upload my packaged Windows binary.

[Ivan De Marino]

Yes, GhostDriver 1.0.2 will be.

Pull request provided: https://github.com/ariya/phantomjs/pull/374

[Ivan De Marino]

I'm looking into a possible regression with Element Clicking in GhostDriver 1.0.1.

I'll be back as soon as possible.

--
You received this message because you are subscribed to the Google Groups "phantomjs" group.
Visit this group at http://groups.google.com/group/phantomjs?hl=en.

[Dav Glass]

Grover tests all pass as well as using it to test the YUI source tree..

Ship It!!

--
Dav Glass
davg...@gmail.com
blog.davglass.com


+ Windows: n. - The most successful computer virus, ever. +
+ A computer without a Microsoft operating system is like a dog
    without bricks tied to its head +
+ A Microsoft Certified Systems Engineer is to computing what a
   McDonalds Certified Food Specialist is to fine cuisine  +

[Ariya Hidayat]

Thanks for all the testing!

BTW, has anyone managed to verify the WOFF support on OS X? It does
not seem to work for me.

Also, the release notes (http://phantomjs.org/release-1.8.html) could
use some love. If someone wants to contribute, it's in the gh-pages
branch. I also could use another pair of eyes (Ivan or Jim?) to make
sure I didn't write something non-sense on the topic of WebDriver
integration.


Thanks!

Best regards,

[Vitaliy Slobodin]

WOFF support is disabled only in one case, when you build WebKit with defined option OPENTYPE_SANITIZER. I'll check this out.
I have no OS X, so I can't test all my changes on all supporting platforms. :(

[Ariya Hidayat]

From my quick test, seems that the font is recognized. However,
sniffing the network traffic does not seems to show that the font file
is being requested.

Would be interesting to see the network requests and responses when
WOFF is rendered correctly.


Regards,

[Ariya Hidayat]

For simple WOFF testing, I've prepared this page:
http://ariya.github.com/html/webfont/. It should be possible to test
this just by running our rasterize.js example on that URL.

[Vitaliy Slobodin]

Yes, I was able to reproduce it on Windows.
WOFF support completely broken now.

[Ivan De Marino]

I have some time to kill this afternoon: I'll get on the release page.

-----
Ivan De Marino
Coder, Cook, Cyclist, Gamer

Sent while standing on one leg

[Ivan De Marino]

https://github.com/ariya/phantomjs/pull/376

--
You received this message because you are subscribed to the Google Groups "phantomjs" group.
Visit this group at http://groups.google.com/group/phantomjs?hl=en.

[Ariya Hidayat]

> https://github.com/ariya/phantomjs/pull/376

Thanks, I've merged that.

I also tried WOFF with Windows, it's also broken there. I don't think
I'll postpone the 1.8.0 tagging because of that. If this turns out to
be an easy fix, we can always have it later.


Regards,

[Ariya Hidayat]

Strange, because my Windows build gives more test failures. I hope
it's not because it's on Windows 8.

In all cases, I'll upload my Windows binary package soon-ish.

[Vitaliy Slobodin]

Agreed. Let's postpone this issue (with WOFF) to the next release.
I have the fix for it, but I want to perform more tests.

Ariya Hidayat

Saturday, December 22, 2012 7:48 AM

Thanks, I've merged that.

I also tried WOFF with Windows, it's also broken there. I don't think
I'll postpone the 1.8.0 tagging because of that. If this turns out to
be an easy fix, we can always have it later.


Regards,

--
Ariya Hidayat, http://ariya.ofilabs.com
http://twitter.com/ariyahidayat
http://gplus.to/ariyahidayat

Ivan De Marino

Friday, December 21, 2012 9:37 PM

https://github.com/ariya/phantomjs/pull/376

--

Ivan De Marino

Coder, Technologist, Cook, Italian

blog.ivandemarino.me | www.linkedin.com/in/ivandemarino | twitter.com/detronizator

--
You received this message because you are subscribed to the Google Groups "phantomjs" group.
Visit this group at http://groups.google.com/group/phantomjs?hl=en.
 
 

Ariya Hidayat

Friday, December 21, 2012 9:22 AM

Thanks for all the testing!

BTW, has anyone managed to verify the WOFF support on OS X? It does
not seem to work for me.

Also, the release notes (http://phantomjs.org/release-1.8.html) could
use some love. If someone wants to contribute, it's in the gh-pages
branch. I also could use another pair of eyes (Ivan or Jim?) to make
sure I didn't write something non-sense on the topic of WebDriver
integration.


Thanks!

Best regards,

--
Ariya Hidayat, http://ariya.ofilabs.com
http://twitter.com/ariyahidayat
http://gplus.to/ariyahidayat

Dav Glass

Wednesday, December 19, 2012 7:37 PM

Grover tests all pass as well as using it to test the YUI source tree..

Ship It!!

--
Dav Glass
davg...@gmail.com
blog.davglass.com


+ Windows: n. - The most successful computer virus, ever. +
+ A computer without a Microsoft operating system is like a dog
    without bricks tied to its head +
+ A Microsoft Certified Systems Engineer is to computing what a
   McDonalds Certified Food Specialist is to fine cuisine  +

--
You received this message because you are subscribed to the Google Groups "phantomjs" group.
Visit this group at http://groups.google.com/group/phantomjs?hl=en.
 
 

Nicolas Perriault

Wednesday, December 19, 2012 3:19 PM

On Wed, Dec 19, 2012 at 11:27 AM, Nicolas Perriault

[Ariya Hidayat]

For some reasons, I encountered a critical linking problem when
building for 32-bit Linux:

/usr/bin/ld: fatal error: ../bin/phantomjs: mmap: failed to allocate
688864056 bytes for output file: Cannot allocate memory

Pushing the VM memory to 8 GB also did not help. I'm not sure if it's
a problem with my Vagrant setup because I did successfully create the
64-bit package just fine.

Jon, any idea what I've done wrong there?

Thanks!

[Ariya Hidayat]

And unfortunately, nothing is worse than GitHub being down
(http://status.github.com/messages) right after we have a release
ready.

Sigh, so much for moving everything to one place...

[Ariya Hidayat]

Just blogged about it:
http://ariya.ofilabs.com/2012/12/phantomjs-1-8-blue-winter-rose.html.
Feel free to spread the news, tweet about it, pass it to social/geek
side!

Special thanks to all contributors. You guys rock!


Best regards,

[Ariya Hidayat]

If this crash is about font loading on OS X, I'll be happy to
investigate as long as there's an easy way for me to reproduce it. See
my comment on https://code.google.com/p/phantomjs/issues/detail?id=690#c9.


Regards,

[Ariya Hidayat]

> /usr/bin/ld: fatal error: ../bin/phantomjs: mmap: failed to allocate
> 688864056 bytes for output file: Cannot allocate memory
>
> Pushing the VM memory to 8 GB also did not help. I'm not sure if it's
> a problem with my Vagrant setup because I did successfully create the
> 64-bit package just fine.

Just another update. If I build it using Ubuntu 11.04 Vagrant box,
then everything is fine.