[perl #33028] Parrot cores when asked to run a nonexistent bytecode file
Dan Sugalski
# Please include the string: [perl #33028]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org:80/rt3/Ticket/Display.html?id=33028 >
A plain
./parrot foo.pbc
when foo.pbc doesn't exist triggers a core dump on OS X.
--
Dan
--------------------------------------it's like this-------------------
Dan Sugalski even samurai
d...@sidhe.org have teddy bears and even
teddy bears get drunk
Chromatic
> A plain
>
> ./parrot foo.pbc
>
> when foo.pbc doesn't exist triggers a core dump on OS X.
The problem is in embed.c not checking the results of
Parrot_locate_runtime_file(). Here's a naive patch.
Is there a good place to put tests for this? I'm not sure how the test
harness could invoke this correctly.
-- c
Matthew Zimmerman
> # New Ticket Created by Dan Sugalski
> # Please include the string: [perl #33028]
> # in the subject line of all future correspondence about this issue.
> # <URL: http://rt.perl.org:80/rt3/Ticket/Display.html?id=33028 >
>
>
> A plain
>
> ./parrot foo.pbc
>
> when foo.pbc doesn't exist triggers a core dump on OS X.
strlen() is puking on the NULL return from Parrot_locate_runtime_file()
in Parrot_readbc. Attached patch fixes this behavior.
--
Matt
Matthew Zimmerman
Interdisciplinary Biophysics, University of Virginia
http://www.people.virginia.edu/~mdz4c/
Matthew Zimmerman
> # Please include the string: [perl #33028]
> # in the subject line of all future correspondence about this issue.
> # <URL: http://rt.perl.org:80/rt3/Ticket/Display.html?id=33028 >
>
>
> A plain
>
> ./parrot foo.pbc
>
> when foo.pbc doesn't exist triggers a core dump on OS X.
Linux too:
matt@tomis ~/personal/devel/parrot $ ./parrot this-doesnt-exist.pbc
Segmentation fault
matt@tomis ~/personal/devel/parrot $ ./parrot this-doesnt-exist.pasm
Error reading source file this-doesnt-exist.pasm.
matt@tomis ~/personal/devel/parrot $ ./parrot this-doesnt-exist.imc
Error reading source file this-doesnt-exist.imc.
matt@tomis ~/personal/devel/parrot $ ./parrot
this-doesnt-exist.arbitraryextension
Error reading source file this-doesnt-exist.arbitraryextension.
matt@tomis ~/personal/devel/parrot $ uname -a
Linux tomis.med.virginia.edu 2.6.8-1.521smp #1 SMP Mon Aug 16 09:25:06
EDT 2004 i686 i686 i386 GNU/Linux
Matthew Zimmerman
> On Mon, 2004-12-13 at 07:44 -0800, Dan Sugalski wrote:
>
>>A plain
>>
>> ./parrot foo.pbc
>>
>>when foo.pbc doesn't exist triggers a core dump on OS X.
>
>
> The problem is in embed.c not checking the results of
> Parrot_locate_runtime_file(). Here's a naive patch.
[snip chromatic's fine patch, very similar to mine]
I'm going to have to stop sending patches if it's going to take 5 hours
for my messages to get to the list. You guys are so damned fast, I can't
compete! :)
Leopold Toetsch
> strlen() is puking on the NULL return from Parrot_locate_runtime_file()
> in Parrot_readbc. Attached patch fixes this behavior.
Thanks, applied.
leo
Nicholas Clark
> I'm going to have to stop sending patches if it's going to take 5 hours
> for my messages to get to the list. You guys are so damned fast, I can't
> compete! :)
I think that your messages hit the moderator, as your address wasn't known
to the list, whereas chromatic's address is, so his messages go direct.
I believe that the fact that your messages got to the list means that now
all your messages go direct, and should get here faster.
I'm inferring the moderator because your messages have all these headers:
Delivered-To: mailing list perl6-i...@perl.org
Delivered-To: moderator for perl6-i...@perl.org
Delivered-To: perl6-i...@perl.org
whereas chromatic's doesn't have the Delivered-To: moderator header.
Nicholas Clark