Pdfium Build Issue - is_official_build
223 views
Skip to first unread message
rweldin
May 9, 2020, 3:06:50 PM5/9/20
to pdfium
When updating Pdfium from the current commit, 3ea38438da69868f33aac23ce7d1b3575479fb0a, I ran into an issue which I tracked down to
the "is_official_build" argument when using gn args. If
"is_official_build = true" is included I get the errors at the bottom
of this message. If I exclude that argument the build is successful. I'm on Windows 10 x64 and the arguments used to generate the error were:
pdf_is_standalone = true
is_component_build = false
is_official_build = true
is_debug = false
pdf_enable_xfa = false
pdf_enable_v8 = false
target_cpu = "x64"
is_component_build = false
is_official_build = true
is_debug = false
pdf_enable_xfa = false
pdf_enable_v8 = false
target_cpu = "x64"
If you need any additional information please let me know.
Thanks,
Ryan
C:\src\repo\pdfium>gn args .
Waiting for editor on "C:\src\repo\pdfium\args.gn"...
Generating files...
C:/src/depot_tools/bootstrap-3_8_0_chromium_8_bin/python/bin/python.exe: can't open file 'C:/src/repo/pdfium/tools/update_pgo_profiles.py': [Errno 2] No such file or directory
ERROR at //build/config/compiler/pgo/BUILD.gn:51:35: Script returned non-zero exit code.
pgo_data_path = rebase_path(exec_script("//tools/update_pgo_profiles.py",
^----------
Current dir: C:/src/repo/pdfium
Command: C:/src/depot_tools/bootstrap-3_8_0_chromium_8_bin/python/bin/python.exe C:/src/repo/pdfium/tools/update_pgo_profiles.py --target win64 get_profile_path
Returned 2.
See //build/config/BUILDCONFIG.gn:439:3: which caused the file to be included.
"//build/config/compiler/pgo:default_pgo_flags",
^----------------------------------------------
Waiting for editor on "C:\src\repo\pdfium\args.gn"...
Generating files...
C:/src/depot_tools/bootstrap-3_8_0_chromium_8_bin/python/bin/python.exe: can't open file 'C:/src/repo/pdfium/tools/update_pgo_profiles.py': [Errno 2] No such file or directory
ERROR at //build/config/compiler/pgo/BUILD.gn:51:35: Script returned non-zero exit code.
pgo_data_path = rebase_path(exec_script("//tools/update_pgo_profiles.py",
^----------
Current dir: C:/src/repo/pdfium
Command: C:/src/depot_tools/bootstrap-3_8_0_chromium_8_bin/python/bin/python.exe C:/src/repo/pdfium/tools/update_pgo_profiles.py --target win64 get_profile_path
Returned 2.
See //build/config/BUILDCONFIG.gn:439:3: which caused the file to be included.
"//build/config/compiler/pgo:default_pgo_flags",
^----------------------------------------------
rweldin
May 10, 2020, 9:52:03 AM5/10/20
to pdfium
This issue appears to be due to https://chromium.googlesource.com/chromium/src/+/da893991
Setting chrome_pgo_phase=0 in args.gn allowed me to use is_official_build = true and fixed the issue for me.
Lei Zhang
May 14, 2020, 6:46:35 PM5/14/20
to rweldin, pdfium
FWIW, there's a thread about is_official_build and PGO on
chromium-dev: https://groups.google.com/a/chromium.org/d/topic/chromium-dev/-0t4s0RlmOI/discussion
> --
> You received this message because you are subscribed to the Google Groups "pdfium" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to pdfium+un...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/pdfium/8df319ab-b838-4ba9-8c0d-3a5a39557985%40googlegroups.com.
chromium-dev: https://groups.google.com/a/chromium.org/d/topic/chromium-dev/-0t4s0RlmOI/discussion
> You received this message because you are subscribed to the Google Groups "pdfium" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to pdfium+un...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/pdfium/8df319ab-b838-4ba9-8c0d-3a5a39557985%40googlegroups.com.
Reply all
Reply to author
Forward
0 new messages