What is the best way to ask questions if I'm reviewing some code and I think I see a problem, or I need some clarification? I know GitHub has a commenting feature for pull requests and on blame views but there is no way to simply place comments on arbitrary lines in current files. I also looked for an issue label like "code review" or something similar and I didn't notice one.Examples of what I'm talking about are:1. Why is there no checkSecurity here:as seen for the similar method here:
2. Database listeners are sometimes called for onBeforeTxBegin before the actual transaction object is set for the database. Is this intentional? Examples:
3. DRYcan simply be this.freeze(false);I'm starting to study some of the code and I'm sure I'll have many similar questions. Should these be issues? One issue per file? Which label should I use?
--Best,Shahim
---
You received this message because you are subscribed to the Google Groups "OrientDB" group.
To unsubscribe from this group and stop receiving emails from it, send an email to orient-database+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.