[PATCH] Staging: rtl8712: fix space coding style issue

36 views
Skip to first unread message

haneen

unread,
Feb 6, 2015, 7:37:11 AM2/6/15
to opw-k...@googlegroups.com, haneen
Patch to the rtl8712_cmd.h file for the following checkpatch.pl error:
ERROR: space prohibited before that ',' (ctx:WxW)

Signed-off-by: haneen <hamoha...@gmail.com>
---
drivers/staging/rtl8712/rtl8712_cmd.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl8712_cmd.h b/drivers/staging/rtl8712/rtl8712_cmd.h
index 039ab3e..67e9e91 100644
--- a/drivers/staging/rtl8712/rtl8712_cmd.h
+++ b/drivers/staging/rtl8712/rtl8712_cmd.h
@@ -109,16 +109,16 @@ enum rtl8712_h2c_cmd {
GEN_CMD_CODE(_DisconnectCtrlEx), /*61*/

/* To do, modify these h2c cmd, add or delete */
- GEN_CMD_CODE(_GetH2cLbk) ,
+ GEN_CMD_CODE(_GetH2cLbk),

/* WPS extra IE */
- GEN_CMD_CODE(_SetProbeReqExtraIE) ,
- GEN_CMD_CODE(_SetAssocReqExtraIE) ,
- GEN_CMD_CODE(_SetProbeRspExtraIE) ,
- GEN_CMD_CODE(_SetAssocRspExtraIE) ,
+ GEN_CMD_CODE(_SetProbeReqExtraIE),
+ GEN_CMD_CODE(_SetAssocReqExtraIE),
+ GEN_CMD_CODE(_SetProbeRspExtraIE),
+ GEN_CMD_CODE(_SetAssocRspExtraIE),

/* the following is driver will do */
- GEN_CMD_CODE(_GetCurDataRate) ,
+ GEN_CMD_CODE(_GetCurDataRate),

GEN_CMD_CODE(_GetTxRetrycnt), /* to record times that Tx retry to
* transmit packet after association
--
1.9.1

Julia Lawall

unread,
Feb 6, 2015, 12:54:47 PM2/6/15
to haneen, opw-k...@googlegroups.com
On Fri, 6 Feb 2015, haneen wrote:

> Patch to the rtl8712_cmd.h file for the following checkpatch.pl error:
> ERROR: space prohibited before that ',' (ctx:WxW)
>
> Signed-off-by: haneen <hamoha...@gmail.com>

The name needs to be your full name, as you would have in your passport.
The name also needs to match the name in the From line.

Also, it would be good to hold off on sending patches until the start of
the application period, on February 17. If you send patches now, they may
get overlooked.

julia
> --
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

Haneen Mohammed

unread,
Feb 6, 2015, 3:40:43 PM2/6/15
to opw-k...@googlegroups.com, hamoha...@gmail.com
Noted thanks. For this should I resend the patch in a new thread?

Julia Lawall

unread,
Feb 6, 2015, 3:57:42 PM2/6/15
to Haneen Mohammed, opw-k...@googlegroups.com
On Fri, 6 Feb 2015, Haneen Mohammed wrote:

> Noted thanks. For this should I resend the patch in a new thread?

I think that it would be ok to send it as v2 of your previous patch.

But wait until the application period starts.

julia
Reply all
Reply to author
Forward
0 new messages