Hello,
Thanks for your patch, but the application period doesn't start until mid
February, expected February 17. So that your patches don't get lost and
you get feedback in a timely manner, it would be better to hold off until
then.
However, for some quick feedback on your patch:
In the subject, "aligned" is consistently misspelled. Also, for staging
the subject line should say which staging driver is concerned, because
they are all different. So, probably Staging: emxx_udc:. But you can use
git log --oneline filename to see what is the common subject line for this
kind of driver.
On Thu, 29 Jan 2015, scarlet-erza wrote:
> This patch fixes the
checkpatch.pl warning in the drivers/staging/emuxx_udc/emuxx_udc.h
You don't need to mention the file name.
> WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))
>
> Signed-off-by: scarlet-erza <
navyas...@gmail.com>
You need to use your real name, eg something that could be in your
passport or driver's license. If this is not the name associated with
your email address, then you need to put a fake From: line at the
beginning of your message, with the same information as is shown in the
Signed-off-by: line.
> ---
> ---
There are two occurrences of --- here. Perhaps you added one and another
one was added for you.
The patch does apply fine :)
julia
> drivers/staging/emxx_udc/emxx_udc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h
> index ee1b80d..2ac216f 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.h
> +++ b/drivers/staging/emxx_udc/emxx_udc.h
> @@ -535,7 +535,7 @@ typedef struct _T_FC_REGS {
>
> u8 Reserved1200[0x1000-0x200]; /* Reserved */
>
> -} __attribute__ ((aligned(32))) T_FC_REGS, *PT_FC_REGS;
> +} __aligned(32) T_FC_REGS, *PT_FC_REGS;
>
>
>
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to
opw-kernel+...@googlegroups.com.
> For more options, visit
https://groups.google.com/d/optout.
>