Process of Contributing

[Keary Suska]

I have a list of bugs I came across while developing my last capp project and I plan to fix as many as I can. I have read and understood (I think) the process of contributing as documented but I have a specific question regarding whether I should submit bug reports, and then submit pull requests for the fixes, or simply submit pull requests and explain the issue etc. It looks like both approaches have been used but I would like to use whatever process works best for the core team.

Best,

Keary Suska
Esoteritech, Inc.
"Demystifying technology for your home or business"

[Keary Suska]

Oh, and to follow up, should tests always be a separate commit/pull, or together? My habit is to always combine them—i.e. every commit should have a test committed with it.

Keary Suska
Esoteritech, Inc.
"Demystifying technology for your home or business"

> --
> You received this message because you are subscribed to the Google Groups "Cappuccino & Objective-J" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to objectivej+...@googlegroups.com.
> To post to this group, send email to objec...@googlegroups.com.
> Visit this group at https://groups.google.com/group/objectivej.
> For more options, visit https://groups.google.com/d/optout.

[Martin Carlberg]

Hi Keary,

If you have a solution ready for an issue you can create a pull request directly. If there is an issue already on Github it is good to reference that in the text when creating the pull request.

The test cases (manual or OJTest) should be included in the pull request. If possible, it is nice to have multiple commits in the pull request and a good way is to separate the test cases as a separate commit.

- Martin