ulimit definitive fix

[Antoine Mercadal]

Hey all,

I’ve opened a PR that should fix the ulimit problem once for all.

We had a lot of "fun" tracking down the issue, but we found it. The problem was due to the JSC implementation of OS.popen. When doing a popen, a popenImpl object is returned and it contains 3 streams. These streams were never closed, which leaded to 3 open FDs per popen, which is why it ran out of available FD.

The PR is here:

https://github.com/cappuccino/cappuccino/pull/2346

We’ll test it internally for a bit, then I’ll merge it. If you want to try it, please fell free to report any probem


Thanks!

-- 

Antoine Mercadal

[Martin Carlberg]

Great work!

Thanks,

- Martin

--
You received this message because you are subscribed to the Google Groups "Cappuccino & Objective-J" group.
To unsubscribe from this group and stop receiving emails from it, send an email to objectivej+...@googlegroups.com.
To post to this group, send email to objec...@googlegroups.com.
Visit this group at http://groups.google.com/group/objectivej.
For more options, visit https://groups.google.com/d/optout.

[Aparajita Fishman]

Brilliant! Such a simple fix, but as you say I'm sure it was "fun" tracking that down.

[Dogild]

It was fun yep...

[Antoine Mercadal]

You owe me a restaurant btw :)

-- 

Antoine Mercadal

[Dogild]

I found the line of the problem, you found the solution. 50/50 ^^