TextNodes returning 0 as line number. Zombie bug from libxml2?

[justi...@shopify.com]

Hello,

Preface/libxml2

I've come across a bug that popped up once before in libxml2 back in 2008 where XML_TEXT_NODEs would always return 0 as their line number.

Link: https://mail.gnome.org/archives/xml/2008-July/msg00017.html

It was however patched that day and should have been fixed.

Commit: https://git.gnome.org/browse/libxml2/commit/?id=45efd0878aa56efa4291eec2ecdcff66d2f52fc3

Those three lines that he added still exist in the most current version of libxml2 now just under a conditional check for a (ctxt->linenumbers) flag.

Current Day libxml2: https://git.gnome.org/browse/libxml2/tree/SAX2.c?id=4472c3a5a5b516aaf59b89be602fbce52756c3e9#n1905

Nokogiri

This bug is currently present in Nokogiri 1.6.8.

I've been looking through the source in an attempt to find a fix and I'd appreciate some guidance:

Possibly relevant files:

https://github.com/sparklemotion/nokogiri/blob/8e305e4e3d0ab697d1c6bc506398fb3007baf874/ext/nokogiri/xml_node.c#L1258
https://github.com/sparklemotion/nokogiri/blob/027a151102083258f5e297c4fecfddca56904a2a/ext/nokogiri/xml_sax_parser_context.c#L171

Any ideas?

Thanks in advance,

Justin

[Mike Dalessio]

Hi Justin,

Apologies for not responding for so long. I've converted this into a github issue:

> https://github.com/sparklemotion/nokogiri/issues/1493

and credited you with it. I'll try to take a look in the next week or so, but this week is crazy because I'm a co-organizer of GORUCO which is this weekend.

Thanks for your patience,

-mike

--
You received this message because you are subscribed to the Google Groups "nokogiri-talk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to nokogiri-tal...@googlegroups.com.
To post to this group, send email to nokogi...@googlegroups.com.
Visit this group at https://groups.google.com/group/nokogiri-talk.
For more options, visit https://groups.google.com/d/optout.

[justi...@shopify.com]

Hey Mike,

Just checking in on this, is there any way I could help you here?

This bug is currently a blocker for us and I'd be willing to do whatever it takes to fix it.

Thanks for your time,

Justin