Can't make nginx 1.13.4 with ngx_pagespeed-latest-stable

[Jacob Share]

I originally posted this issue to Nginx's Trac, and they said the issue was in ngx_pagespeed and I should post here instead.

Where nginx -V is:

nginx version: nginx/1.13.3
built by gcc 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.4)
built with OpenSSL 1.1.0f  25 May 2017
TLS SNI support enabled
configure arguments: --prefix=/usr/share/nginx
--sbin-path=/usr/sbin/nginx --conf-path=/etc/nginx/nginx.conf
--error-log-path=/var/log/nginx/error.log
--http-client-body-temp-path=/var/lib/nginx/body
--http-fastcgi-temp-path=/var/lib/nginx/fastcgi
--http-log-path=/var/log/nginx/access.log
--http-proxy-temp-path=/var/lib/nginx/proxy
--http-scgi-temp-path=/var/lib/nginx/scgi
--http-uwsgi-temp-path=/var/lib/nginx/uwsgi
--lock-path=/var/lock/nginx.lock --pid-path=/var/run/nginx.pid
--with-pcre-jit --with-debug --with-http_addition_module
--with-http_dav_module --with-http_geoip_module
--with-http_gzip_static_module --with-http_image_filter_module
--with-http_realip_module --with-http_stub_status_module
--with-http_ssl_module --with-http_sub_module --with-http_xslt_module
--with-mail --with-mail_ssl_module --with-http_v2_module --with-threads
--add-module=/root/ngx_pagespeed-latest-stable
--add-module=/root/ngx_cache_purge-2.3        

When I try to make nginx with these arguments, the make fails with:

        -o objs/addon/src/ngx_pagespeed.o \
        /root/ngx_pagespeed-latest-stable/src/ngx_pagespeed.cc
/root/ngx_pagespeed-latest-stable/src/ngx_pagespeed.cc: In function ‘ngx_int_t net_instaweb::{anonymous}::ps_preaccess_handler(ngx_http_request_t*)’:
/root/ngx_pagespeed-latest-stable/src/ngx_pagespeed.cc:3011:31: error: ‘ngx_http_core_try_files_phase’ was not declared in this scope
   while (ph[i + 1].checker != ngx_http_core_try_files_phase &&
                               ^
objs/Makefile:1630: recipe for target 'objs/addon/src/ngx_pagespeed.o' failed
make[1]: *** [objs/addon/src/ngx_pagespeed.o] Error 1
make[1]: Leaving directory '/root/temp/nginx-1.13.4'
Makefile:8: recipe for target 'build' failed
make: *** [build] Error 2

What do you think?

Thanks

Jacob

[Otto van der Schaaf]

This was tracked in https://github.com/pagespeed/ngx_pagespeed/issues/1451  

(and adressed in https://github.com/pagespeed/ngx_pagespeed/pull/1453)

Otto

--
You received this message because you are subscribed to the Google Groups "ngx-pagespeed-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ngx-pagespeed-di...@googlegroups.com.
Visit this group at https://groups.google.com/group/ngx-pagespeed-discuss.
For more options, visit https://groups.google.com/d/optout.

[Jacob Share]

Once I patched ngx_pagespeed.cc, I was able to build nginx 1.13.4. 

Thanks Otto!