Announcing ngx_pagespeed release 1.9.32.6-beta

[Jeffrey Crowell]

The PageSpeed team is pleased to announce a new beta release, version 1.9.32.6. This release contains the following bug fixes.

Issues Resolved

Issues Affecting both Nginx and Apache

• Issue 972 LoadFromFile logs errors on 404s (3d44cc)

• Issue 992 Segfault in https fetching (b4f4ae9)

• Issue 1039 Noisy leaked_rewrite_drivers on destruction message (58aaa4)

• Issue 1040 inline_google_font_css no longer works in Chrome (01045a)

• Issue 1043 Source maps set ?PageSpeed=off for .pagespeed. sources (9d6d08)

• Issue 1050 X-Sendfile messages should not be cached (a49af6)

• Issue 1060 Spurious DownstreamCacheRebeaconingKey Warning (0f2a6f)

• Issue 1068 Empty resources should not be cached. (741a86, 3ac019)

• Issue 1070 Opera Mini should not be sent lazyload_images JS (0a90bb)

• Issue 1078 Image rewriting dcheck-fails on images with invalid dimensions (166151)

• Issue 1087 Critical images js doesn't play well with display (f01252)

• Issue 1106 If-Modified-Since not working with IPRO (9ba250)

• Issue 1109 Can't set MessageBufferSize to 0 (16e9f4)

• Issue 1116 Won't compile with gcc 4.6.3 (3f9176)

Nginx-specific Issues

• Issue 864 Server header dropped (a9c292)

• Issue 888 Check-fails on invalid urls instead of declining them. (9da85b)

• Issue 913 Incorrect Date header on 32-bit (7355f2)

• Issue 948 Fails to build with nginx 1.7.11 and --with-threads (a81cc9)

• Issue 956 DCheck failure if pagespeed is off and no file cache path is configured (c925b4)

• Issue 965 PageSpeed returning partial web pages (b9ca5d)

Installation Instructions

To install it see: https://developers.google.com/speed/pagespeed/module/build_ngx_pagespeed_from_source

The installation process is the same even if you've already installed a previous version.

Jeff Crowell

PageSpeed Team

Google

[shiz]

build failed w nginx 1.9.3 (previous built fine w pagespeed 1.9.32.4)

/usr/local/src/pagespeed-ngx/nginx-1.9.3/debian/modules/ngx_pagespeed/psol/include/net/instaweb/system/public/in_place_resource_recorder.h:120:8: note:   candidate expects 2 arguments, 1 provided

objs/Makefile:1794: recipe for target 'objs/addon/src/ngx_pagespeed.o' failed

[Paul Garrison]

Same build error here :-(

...

[Jeff Kaufman]

It's also not compiling against mainling nginx:

NPS_VERSION=1.9.32.6

wget https://github.com/pagespeed/ngx_pagespeed/archive/release-${NPS_VERSION}-beta.zip

unzip release-${NPS_VERSION}-beta.zip

cd ngx_pagespeed-release-${NPS_VERSION}-beta/

wget https://dl.google.com/dl/page-speed/psol/${NPS_VERSION}.tar.gz

tar -xzvf ${NPS_VERSION}.tar.gz  # extracts to psol/

cd ..

NGINX_VERSION=1.8.0

wget http://nginx.org/download/nginx-${NGINX_VERSION}.tar.gz

tar -xvzf nginx-${NGINX_VERSION}.tar.gz

cd nginx-${NGINX_VERSION}/

configure --add-module=/path/to/ngx_pagespeed-release-${NPS_VERSION}-beta

make

...

ngx_pagespeed-release-1.9.32.6-beta/src/ngx_pagespeed.cc:1713:42: error: no matching function for call to ‘net_instaweb::InPlaceResourceRecorder::DoneAndSetHeaders(NULL)’

     ctx->recorder->DoneAndSetHeaders(NULL);  // Deletes recorder.

ngx_pagespeed-release-1.9.32.6-beta/psol/include/net/instaweb/system/public/in_place_resource_recorder.h:120:8: note: void net_instaweb::InPlaceResourceRecorder::DoneAndSetHeaders(net_instaweb::ResponseHeaders*, bool)

   void DoneAndSetHeaders(ResponseHeaders* response_headers,

ngx_pagespeed-release-1.9.32.6-beta/src/ngx_pagespeed.cc:2509:57: error: no matching function for call to ‘net_instaweb::InPlaceResourceRecorder::DoneAndSetHeaders(net_instaweb::ResponseHeaders*)’

       ctx->recorder->DoneAndSetHeaders(&response_headers);

ngx_pagespeed-release-1.9.32.6-beta/psol/include/net/instaweb/system/public/in_place_resource_recorder.h:120:8: note: void net_instaweb::InPlaceResourceRecorder::DoneAndSetHeaders(net_instaweb::ResponseHeaders*, bool)

   void DoneAndSetHeaders(ResponseHeaders* response_headers,

ngx_pagespeed-release-1.9.32.6-beta/psol/include/net/instaweb/system/public/in_place_resource_recorder.h:120:8: note:   candidate expects 2 arguments, 1 provided

Looking into it.

--
You received this message because you are subscribed to the Google Groups "ngx-pagespeed-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ngx-pagespeed-di...@googlegroups.com.
Visit this group at http://groups.google.com/group/ngx-pagespeed-discuss.
For more options, visit https://groups.google.com/d/optout.

[Jeff Kaufman]

Looks like the fix for https://github.com/pagespeed/mod_pagespeed/issues/1081 isn't on the release branch.

It did get merged onto master prematurely in https://github.com/pagespeed/ngx_pagespeed/commit/4df7460d62ee9551a62ed589548300215f598603 (May 15)

This was wrong, so it was reverted in https://github.com/pagespeed/ngx_pagespeed/commit/19ebf69badb0d1b0867eaa3fd9b0c430f82753da (Jun 10)

I've reverted the revert (0f3f268) so people building from master should be fine.  I'll fix the binary on dl.google.com next.

[Jeff Kaufman]

This should be fixed now:

* master and release-1.9.32.6-beta branches have the missing commit

* tag v1.9.32.6-beta has it

* https://github.com/pagespeed/ngx_pagespeed/archive/release-1.9.32.6-beta.zip is confirmed working

[shiz]

Nice work, Jeff!

[Centmin Mod George]

Compiles fine for me now on nginx 1.9.3 :)

[Hans van Eijsden]

For me, still problems.

I've done a "git checkout latest-beta" for pagespeed and "git checkout release-1.9.32.6-beta" for ngx_pagespeed.

With icc still no luck:

icc -c -xHOST -O3 -ipo -no-prec-div -qopenmp -pthread -unroll-aggressive -qopt-prefetch -DTCP_FASTOPEN=23 -xHOST -O3 -ipo -no-prec-div -qopenmp -pthread -unroll-aggressive -qopt-prefetch   -I src/core -I src/event -I src/event/modules -I src/os/unix -I /home/hans/mod_pagespeed/src -I /home/hans/mod_pagespeed/src/third_party/chromium/src -I /home/hans/mod_pagespeed/src/third_party/google-sparsehash/src -I /home/hans/mod_pagespeed/src/third_party/google-sparsehash/gen/arch/linux/x64/include -I /home/hans/mod_pagespeed/src/third_party/protobuf/src -I /home/hans/mod_pagespeed/src/third_party/re2/src -I /home/hans/mod_pagespeed/src/out/Release/obj/gen -I /home/hans/mod_pagespeed/src/out/Release/obj/gen/protoc_out/instaweb -I /home/hans/mod_pagespeed/src/third_party/apr/src/include -I /home/hans/mod_pagespeed/src/third_party/aprutil/src/include -I /home/hans/mod_pagespeed/src/third_party/apr/gen/arch/linux/x64/include -I /home/hans/mod_pagespeed/src/third_party/aprutil/gen/arch/linux/x64/include -I /usr/local/src/openssl-1.0.2d/.openssl/include -I objs -I src/http -I src/http/modules -I src/mail -I src/stream \
-o objs/addon/src/ngx_pagespeed.o \
/home/hans/ngx_pagespeed/src/ngx_pagespeed.cc
/home/hans/ngx_pagespeed/src/ngx_pagespeed.cc(1713): error #140: too many arguments in function call
      ctx->recorder->DoneAndSetHeaders(NULL, false /* incomplete response */);
                                             ^
/home/hans/ngx_pagespeed/src/ngx_pagespeed.cc(2511): error #140: too many arguments in function call
            cl->buf->last_buf /* response is complete if last_buf is set */);
            ^
compilation aborted for /home/hans/ngx_pagespeed/src/ngx_pagespeed.cc (code 2)
make[1]: *** [objs/addon/src/ngx_pagespeed.o] Fout 2
make[1]: Map '/usr/local/src/nginx-1.9.3' wordt verlaten
make: *** [install] Fout 2

Hans

Op vrijdag 31 juli 2015 00:57:30 UTC+2 schreef Centmin Mod George:

[Hans van Eijsden]

My mistake. I had to remove the whole mod_pagespeed dir and recompile it, to make it work. I think I forgot to do a make clean... it was late already ;-)

It works, thanks!

Hans

Op zaterdag 1 augustus 2015 00:30:54 UTC+2 schreef Hans van Eijsden:

[Akpan Promise]

I use this beta version on Ubuntu 14.04, and Nginx 1.8.0, but when i curl mydomain i dont see any "X-Pagespeed".

plase is there anything i am not doing right?