combine_javascript not combining any script files

[Glenn Slaven]

I have a page with 5 script tags all together at the bottom of the page like this:

<script src="/Scripts/jquery.params.js"></script>

<script src="/Scripts/components/fastclick/lib/fastclick.js"></script>

<script src="/Scripts/components/carousel/jquery.slides.js"></script>

<script src="/Scripts/components/megamenu/jquery.megamenu.js"></script>

<script src="/Scripts/app/app.js"></script>

AvoidRenamingIntrospectiveJavascript is off and CombineAcrossPaths is on (ngx_pagespeed defaults).  However none of these files will get combined.  rewrite_javascript successfully rewrites all the scripts, but they won't combine.  They are collectively 107kb uncompressed, and we have MaxBytes let as the default, so at least some of them should be able to be combined together.

What other situations will cause script files to not be combined?  I can send a url for testing via email.

--

Glenn Slaven

Principal Engineer

Ph: (02) 9119 0444

M: 0433 826 255

www.squixa.com

[Otto van der Schaaf]

You can find a few reasons why combining could fail if you look at this code:

https://code.google.com/p/modpagespeed/source/browse/trunk/src/net/instaweb/rewriter/js_combine_filter.cc#81

Could you be hitting this?: 

"strict mode detection is too conservative": 

https://code.google.com/p/modpagespeed/issues/detail?id=909

Otto

--
You received this message because you are subscribed to the Google Groups "ngx-pagespeed-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ngx-pagespeed-di...@googlegroups.com.
Visit this group at http://groups.google.com/group/ngx-pagespeed-discuss.
For more options, visit https://groups.google.com/d/optout.

[Glenn Slaven]

Yes, I think that is the reason, thanks!

[Jeff Kaufman]

This is now fixed in trunk, and will be in our next release.