[PATCH ee/clean-remove-dirs] t7300-clean: require POSIXPERM for chmod 0 test

48 views
Skip to first unread message

Johannes Sixt

unread,
Aug 11, 2015, 4:29:50 PM8/11/15
to Git Mailing List, msysGit
A test case introduced by 91479b9c (t7300: add tests to document
behavior of clean and nested git) uses 'chmod 0' to verify that a
subdirectory that has an unreadable .git file is not removed. This can
work only when the system pays attention to the permissions set with
'chmod'. Therefore, set the POSIXPERM prerequisite on the test case.

Signed-off-by: Johannes Sixt <j...@kdbg.org>
---
This fixes a new failure in the test suite (t3404.8[67]) on Windows, but
I got around to debug it only now.

t/t7300-clean.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/t7300-clean.sh b/t/t7300-clean.sh
index 32e96da..27557d6 100755
--- a/t/t7300-clean.sh
+++ b/t/t7300-clean.sh
@@ -499,7 +499,7 @@ test_expect_success 'should not clean submodules' '
test_path_is_missing to_clean
'

-test_expect_success 'should avoid cleaning possible submodules' '
+test_expect_success POSIXPERM 'should avoid cleaning possible submodules' '
rm -fr to_clean possible_sub1 &&
mkdir to_clean possible_sub1 &&
test_when_finished "rm -rf possible_sub*" &&
--
2.3.2.245.gb5bf9d3

Junio C Hamano

unread,
Aug 11, 2015, 6:17:20 PM8/11/15
to Johannes Sixt, Git Mailing List, msysGit
Thanks.
Reply all
Reply to author
Forward
0 new messages