[bug] gitk: changing font size
Stephan Hennig
reducing font size in gitk with CTRL-- works, but enlarging font size
fails. Typing CTRL-+ just doesn't have any effect here.
Best regards,
Stephan Hennig
> $ git version
> git version 1.5.4.rc2.935.ga142f
Johannes Schindelin
Only Ctrl "=" was bound to increase the font size, probably because
English keyboards have the plus on the same key as the equal sign.
However, not the whole world is English, and at least with some
other keyboard layouts, Ctrl "+" did not work as documented.
Noticed by Stephan Hennig.
Signed-off-by: Johannes Schindelin <Johannes....@gmx.de>
---
On Thu, 10 Jan 2008, Stephan Hennig wrote:
>
> Hi,
>
> reducing font size in gitk with CTRL-- works, but enlarging font
> size fails. Typing CTRL-+ just doesn't have any effect here.
This is no bug in msysgit, but in gitk.
Paul, please apply.
gitk | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/gitk b/gitk
index 1da0b0a..462f6aa 100644
--- a/gitk
+++ b/gitk
@@ -996,6 +996,7 @@ proc makewindow {} {
bind . <$M1B-r> dosearchback
bind . <$M1B-s> dosearch
bind . <$M1B-equal> {incrfont 1}
+ bind . <$M1B-plus> {incrfont 1}
bind . <$M1B-KP_Add> {incrfont 1}
bind . <$M1B-minus> {incrfont -1}
bind . <$M1B-KP_Subtract> {incrfont -1}
Johannes Sixt
> Only Ctrl "=" was bound to increase the font size, probably because
> English keyboards have the plus on the same key as the equal sign.
> However, not the whole world is English, and at least with some
> other keyboard layouts, Ctrl "+" did not work as documented.
>
> Noticed by Stephan Hennig.
>
^^^^^^^^^^^^^^...
WTF is going on these days?
[note: yours, git ML and msysgit ML adresses corrected manually]
-- Hannes
Julio Espinoza-Sokal
I don't know if this is new, but it seems that's a feature of Gmane to
prevent spam.
http://gmane.org/tmda.php
Johannes Schindelin
On Fri, 11 Jan 2008, Johannes Sixt wrote:
> Johannes Schindelin schrieb:
>
> > Signed-off-by: Johannes Schindelin
> > <Johannes.Schind...@public.gmane.org>
> ^^^^^^^^^^^^^^...
> WTF is going on these days?
>
> [note: yours, git ML and msysgit ML adresses corrected manually]
Umm. The copy of my mail _I_ got via vger.kernel.org was _not_ corrupted.
So I think the problem is on the viewer's side (IOW gmane), not the sender
or the mailing list...
Ciao,
Dscho
Stephan Hennig
>
> Only Ctrl "=" was bound to increase the font size, probably because
> English keyboards have the plus on the same key as the equal sign.
> However, not the whole world is English, and at least with some
> other keyboard layouts, Ctrl "+" did not work as documented.
>
> Noticed by Stephan Hennig.
>
> Signed-off-by: Johannes Schindelin <Johannes....@gmx.de>
>
> ---
>
> On Thu, 10 Jan 2008, Stephan Hennig wrote:
>
> >
> > Hi,
> >
> > reducing font size in gitk with CTRL-- works, but enlarging font
> > size fails. Typing CTRL-+ just doesn't have any effect here.
>
> This is no bug in msysgit, but in gitk.
>
> Paul, please apply.
The bug is still present in gitk that comes with Msysgit
> $ git version
> git version 1.5.4.rc3.941.gebb79
Best regards,
Stephan Hennig
Johannes Schindelin
[please do not cull me from the Cc' list. It's like answering to what I
said while looking at someone else.]
If you are complaining about msysgit, please do not flood the git list
with your response.
Besides, it is asking a little much after just 4 days for a patch to come
through no less than 4 different repositories: gitk -> git.git ->
mingw.git -> 4msysgit.git.
A patch that you could apply yourself easily, with the further benefit of
being able to added your "Tested-by:" line.
After all, I just worked for you, for free, and I expect something back.
Hth,
Dscho