Frame Pointer Omission Unconditionally Disabled on Win32

[Eric Rahm]

As of landing bug 1322735 [1], we now unconditionally disable frame pointer
omission (FPO) on all win32 builds. FPO was already disabled on
nightly/aurora builds as a side-effect of having profiling enabled, but
will now be disabled in beta (and release eventually) after the next
uplift.

Please note: This does not mean profiling is always enabled, that's still
controlled by the --enable-profiling switch.

The main motivation for this is to get usable crash stacks via telemetry
(see bug 1280477 [2]) without the need to have users submit full crash
reports. Comment 0 in bug 1322735 [1] provides further details and analysis.

One thing we want to look out for are talos regressions once this hits
beta, after initial testing on try we determined the few minor regressions
are an acceptable trade off [3].

As a nice side effect we were able to remove the |MOZ_STACKWALKING| define.
Please don't use that anymore.

-e

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1322735
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=1280477
[3] https://bugzilla.mozilla.org/show_bug.cgi?id=1322735#c12

[Aaron Klotz]

This is fantastic news! I hope this sticks!

> _______________________________________________
> dev-platform mailing list
> dev-pl...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform