Proposal: Email individual patch authors who improve performance

[Matt Brubeck]

I've posted a patch that would change how the graph server sends email
when a performance *improvement* is detected:
https://bugzilla.mozilla.org/show_bug.cgi?id=904250

Emails about regressions would be unchanged. Emails about improvements
would now be sent to individual patch authors using the same logic as
regression emails:

* If there are up to five authors in the regression range, email
dev-tree-management and each of the patch authors.
* If there are more than five authors, just email dev-tree-management.

I've spoken to other developers in a few places, and most were in favor
of this change. Those who don't want the extra emails can filter them
out if they want to. Motivations for this change:

- When you are expecting a patch to affect performance, the email is
useful confirmation. Receiving it directly saves you the work of
searching through the mailing list archives or manually inspecting graphs.

- When you're not expecting a performance improvement, it may be
important to know that one has happened so you can figure out why.
(Sometimes it's a sign of a bug, for example if you accidentally
disabled some code.)

- Warm fuzzy feeling for developers who write perf wins!

I think the accuracy of the analysis script is now good enough that this
would not generate too many spurious emails. If you have any opinions
or suggestions about this change, please share them here or in bug 904250!

[Jet Villegas]

This is awesome! Is it possible to see a log of the recipients/patches?

--Jet

_______________________________________________
dev-platform mailing list
dev-pl...@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

[Chris Peterson]

We could also send a weekly congratulations to the person who removed
the most lines of code that week. :)

chris

[Andreas Gal]

+1

Sent from Mobile.

[Jet Villegas]

Sweet! Lots of goodness already in the first e-mail I clicked on:
https://groups.google.com/forum/#!topic/mozilla.dev.tree-management/UcpnVNOdr28

--Jet

----- Original Message -----
From: "Matt Brubeck" <mbru...@mozilla.com>

To: "Jet Villegas" <j...@mozilla.com>
Cc: dev-pl...@lists.mozilla.org
Sent: Tuesday, August 13, 2013 2:01:39 PM
Subject: Re: Proposal: Email individual patch authors who improve performance

On 8/13/2013 1:57 PM, Jet Villegas wrote:
> This is awesome! Is it possible to see a log of the recipients/patches?

Yes - all of the emails for both regressions and improvements are also
sent to the dev-tree-management list, which is archived at
https://groups.google.com/forum/#!forum/mozilla.dev.tree-management

[Mike Hoye]

On 2013-08-12 6:14 PM, Matt Brubeck wrote:
> I've posted a patch that would change how the graph server sends email
> when a performance *improvement* is detected:
> https://bugzilla.mozilla.org/show_bug.cgi?id=904250

This is really great.

Can other addresses be CC'ed when this specifically (and in the future,
other automatically-detectable improvements) are accomplished? I'd like
to be able to automate badge-assignment stuff on Mozillians as much as
possible, and this would be a big help.


- mhoye

[Matt Brubeck]

> On 2013-08-12 6:14 PM, Matt Brubeck wrote:
>> I've posted a patch that would change how the graph server sends email
>> when a performance *improvement* is detected:
>> https://bugzilla.mozilla.org/show_bug.cgi?id=904250

I landed this patch, and it will go live with the next graph server
deployment. I also just landed some patches that should reduce the main
causes of false alarms (bug 904322, bug 879903) to minimize any
noise/spam from this change.

On 8/16/2013 11:27 AM, Mike Hoye wrote:
> Can other addresses be CC'ed when this specifically (and in the future,
> other automatically-detectable improvements) are accomplished? I'd like
> to be able to automate badge-assignment stuff on Mozillians as much as
> possible, and this would be a big help.

Yes -- you can either subscribe your address to the dev-tree-management
mailing list to receive all of the emails, or you could add additional
logic to the "emailWarning" function in this code:
http://hg.mozilla.org/graphs/file/tip/server/analysis/analyze_talos.py

If you want to do the latter, please file a bug in the "Release
Engineering: Tools" component in Bugzilla.