redundant(?) code churn and code style issues in bug 525063

[Jonathan Kew]

The huge patch that recently hit mozilla-central in bug 525063 makes me
a bit sad. Did we really need to do this? On this scale?

It's presumably auto-generated by a static-analysis tool or something
like that, but ISTM it has been overly aggressive, adding a lot more
code churn than necessary (as well as committing some pretty extreme
style violations such as over-long lines).

For example, it has added explicit initializers to constructors in cases
where the members were already default-initialized at the point of
declaration.

Couldn't we have been a little less heavy-handed here?

(I would have just commented in the bug, but don't have access to it....)

JK

[Kartikaya Gupta]

On Fri, Apr 13, 2018 at 6:18 AM, Jonathan Kew <jfkt...@gmail.com> wrote:
> It's presumably auto-generated by a static-analysis tool or something like
> that, but ISTM it has been overly aggressive, adding a lot more code churn
> than necessary (as well as committing some pretty extreme style violations
> such as over-long lines).

+1. I too was sad to see the style violations/general ugliness of the
changes in the patch.

[Nathan Froyd]

FWIW, all these complaints (and more) have been raised in the bug.
I'm not entirely sure what we're going to do yet, but rest assured
that people are definitely aware of the issues.

Thanks,
-Nathan

> _______________________________________________
> dev-platform mailing list
> dev-pl...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform

[Andi-Bogdan Postelnicu]

Hello all,

Right now we are working on backing out the changes the caused this. I will keep you posted when this is done.

P.S it should be done very shortly.

> On 13 Apr 2018, at 15:48, Nathan Froyd <nfr...@mozilla.com> wrote:
>
> we're

[Andi-Bogdan Postelnicu]

I come with a followup on this matter, we’ve backed out the issues. Now the tree should be OK.
Please see:
https://hg.mozilla.org/mozilla-central/rev/8a94faa5cc60495da5d80d4b3c07bf5877d2e6d8 <https://hg.mozilla.org/mozilla-central/rev/8a94faa5cc60495da5d80d4b3c07bf5877d2e6d8>

Thanks,
ANdi

> On 13 Apr 2018, at 15:48, Nathan Froyd <nfr...@mozilla.com> wrote:
>