Intent to ship: shape-outside

[Bradley Werth]

On Monday June 11th, I intend to land Bug 1457297
<https://bugzilla.mozilla.org/show_bug.cgi?id=1457297> which will enable
shape-outside for all channels in Firefox 62. The feature has been on by
default in Nightly 61, and available in other channels behind the
layout.css.shape-outside.enabled pref. Blink and Webkit browsers already
implement this feature.

There are some pending issues in Bug 1466231
<https://bugzilla.mozilla.org/show_bug.cgi?id=1466231> and Bug 1466231
<https://bugzilla.mozilla.org/show_bug.cgi?id=1466231> that should either
be in before 62 merge date or safely uplift-able.

Let me know if there are any concerns, thanks,
Brad

[Emilio Cobos Álvarez]

On 06/08/2018 08:08 PM, Bradley Werth wrote:
> On Monday June 11th, I intend to land Bug 1457297
> <https://bugzilla.mozilla.org/show_bug.cgi?id=1457297> which will enable
> shape-outside for all channels in Firefox 62. The feature has been on by
> default in Nightly 61, and available in other channels behind the
> layout.css.shape-outside.enabled pref. Blink and Webkit browsers already
> implement this feature.

Not necessarily a concern, but do you know what's the state regarding
interop?

I saw you upstreamed a lot of test-cases for the feature and edge cases
while developing it to WPT, which is awesome. Do WebKit and Blink all
pass those tests? If not, why? Are there bugs on file for those?

I know Blink has bugs automatically on file for new WPT failures like
[1], but I think it's still worth to describe why they fail it if we
know why.

Thanks for working on this!

[1]: https://bugs.chromium.org/p/chromium/issues/detail?id=851292

-- Emilio

> There are some pending issues in Bug 1466231
> <https://bugzilla.mozilla.org/show_bug.cgi?id=1466231> and Bug 1466231
> <https://bugzilla.mozilla.org/show_bug.cgi?id=1466231> that should either
> be in before 62 merge date or safely uplift-able.
>
> Let me know if there are any concerns, thanks,
> Brad

> _______________________________________________
> dev-platform mailing list
> dev-pl...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform
>

[Bradley Werth]

On Mon, Jun 11, 2018 at 7:54 AM, Emilio Cobos Álvarez <emi...@crisal.io>
wrote:

> On 06/08/2018 08:08 PM, Bradley Werth wrote:
>
>> On Monday June 11th, I intend to land Bug 1457297
>> <https://bugzilla.mozilla.org/show_bug.cgi?id=1457297> which will enable
>> shape-outside for all channels in Firefox 62. The feature has been on by
>> default in Nightly 61, and available in other channels behind the
>> layout.css.shape-outside.enabled pref. Blink and Webkit browsers already
>> implement this feature.
>>
>
> Not necessarily a concern, but do you know what's the state regarding
> interop?
>
> I saw you upstreamed a lot of test-cases for the feature and edge cases
> while developing it to WPT, which is awesome. Do WebKit and Blink all pass
> those tests? If not, why? Are there bugs on file for those?
>

Some of the WPT I added show interop problems in both WebKit and Blink.
Tests for Bug 1464113 <https://bugzilla.mozilla.org/show_bug.cgi?id=1464113>
and Bug 1460041 <https://bugzilla.mozilla.org/show_bug.cgi?id=1460041>
indicate that other UAs have trouble with shapes defined with negative
offsets relative to their containing blocks. I haven't filed bugs -- I'm
not familiar with the process for those repositories -- and I don't know
whether bugs have been filed.

[Emilio Cobos Álvarez]

The relevant URLs are crbug.com/new and bugs.webkit.org. It would be
useful for us to get feedback from them, and for them to get it triaged
and diagnosed faster. I don't think it's needed for enabling the pref,
but it'd certainly be nice.

Thanks again for all your work on getting this ready for shipping, and
for Ting-Yu for all the previous work! :)

-- Emilio