Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

Intent to Unship: stream decoder for BinHex format

136 views
Skip to first unread message

Shih-Chiang Chien

unread,
Oct 17, 2017, 5:47:24 AM10/17/17
to dev-platform, Thunderbird email developers
Currently on non-Mac platform, firefox will decompression the content while
loading resource with MIME type "application/mac-binhex40". This introduces
the confusion like bug 1390708 when Firefox trying to decode BinHex file.
On Mac platform we already disabled stream decoding of BinHex file.

I tested with Google Chrome 61, Internet Explorer 11, and Safari 11. All
these browsers treat BinHex file as binary file and trigger file download
directly.

I intent to remove all the code that handling BinHex decoding, i.e.
nsBinHex.cpp, from mozilla-central if no other project is using it. This
will happen on Firefox 58 if no objection on mailing list and in bug
1390708.

Best Regards,
Shih-Chiang Chien
Mozilla Taiwan

Boris Zbarsky

unread,
Oct 17, 2017, 10:45:27 AM10/17/17
to
On 10/17/17 5:47 AM, Shih-Chiang Chien wrote:
> I intent to remove all the code that handling BinHex decoding, i.e.
> nsBinHex.cpp, from mozilla-central if no other project is using it.

The code was originally added for mailnews. See
https://bugzilla.mozilla.org/show_bug.cgi?id=81352

Please double-check that this use case does not get broken, or condition
the code to be mailnews-only or something.

-Boris

Myk Melez

unread,
Oct 17, 2017, 8:14:50 PM10/17/17
to Boris Zbarsky, dev-pl...@lists.mozilla.org
> Boris Zbarsky <mailto:bzba...@mit.edu>
> 2017 October 17 at 07:45
> Please double-check that this use case does not get broken, or
> condition the code to be mailnews-only or something.
Shouldn't the code rather move to comm-central if it's specific to mailnews?

-myk

Boris Zbarsky

unread,
Oct 17, 2017, 8:40:49 PM10/17/17
to
On 10/17/17 8:12 PM, Myk Melez wrote:
> Shouldn't the code rather move to comm-central if it's specific to
> mailnews?

That would be fine too, yes.

-Boris

Joshua Cranmer 🐧

unread,
Oct 18, 2017, 8:47:32 AM10/18/17
to
FWIW, I've considered ripping out the binhex decoding from mailnews code
anyways.

--
Joshua Cranmer
Thunderbird and DXR developer
Source code archæologist

Eric Shepherd (Sheppy)

unread,
Oct 25, 2017, 3:46:11 PM10/25/17
to Joshua Cranmer 🐧, dev-pl...@lists.mozilla.org
Man… It’s weird that this makes me all nostalgic. :)


Eric Shepherd
Senior Technical Writer, MDN
MDN: https://developer.mozilla.org/
Blog: https://www.bitstampede.com/

On October 18, 2017 at 8:50:20 AM, Joshua Cranmer 🐧 (pidg...@gmail.com)
wrote:

Shih-Chiang Chien

unread,
Nov 14, 2017, 8:06:00 PM11/14/17
to dev-platform
Lastest update: nsBinHexDecoder is going to be removed from both
mozilla-central and comm-central.
Patch for mozilla-central has been landed on Firefox 59 (see bug 1390708)
and the work for comm-central will be tracked by Bug 1417187.

Best Regards,
Shih-Chiang Chien
Mozilla Taiwan

On Thu, Oct 26, 2017 at 3:45 AM, Eric Shepherd (Sheppy) <
eshe...@mozilla.com> wrote:

> Man… It’s weird that this makes me all nostalgic. :)
>
>
> Eric Shepherd
> Senior Technical Writer, MDN
> MDN: https://developer.mozilla.org/
> Blog: https://www.bitstampede.com/
>
> On October 18, 2017 at 8:50:20 AM, Joshua Cranmer 🐧 (pidg...@gmail.com)
> wrote:
>
> FWIW, I've considered ripping out the binhex decoding from mailnews code
> anyways.
> _______________________________________________
> dev-platform mailing list
> dev-pl...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform
>
0 new messages