Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

Remove l10n/shared path handler in httpds.js/bootstrap.js

14 views
Skip to first unread message

Yuren Ju

unread,
Feb 18, 2014, 2:03:58 AM2/18/14
to dev-...@lists.mozilla.org, Axel Hecht
Hi folks,

we will copy all apps into build_stage for assembling app, so we will
remove l10n and shared directory path handler in httpd.js/bootstrap.js and
point app directory to build_stage/$APP to get clearer httpd extension.

for l10n, we can use |make watch| to monitor files change in gaia and
LOCALE_BASEDIR.

I will work on it after bug 897352, so please let me know if you have any
concern.

Julien Wajsberg

unread,
Feb 18, 2014, 2:49:46 AM2/18/14
to Yuren Ju, dev-...@lists.mozilla.org, Axel Hecht
How will this work with the "save-reload-test" workflow we're used to
and rely on? Do we need to keep "make watch" running?

signature.asc

Yuren Ju

unread,
Feb 18, 2014, 3:40:48 AM2/18/14
to Julien Wajsberg, Axel Hecht, dev-...@lists.mozilla.org
it will be a problem for unit test workflow that I didn't realize, thank
you Julien.

there are some potential solutions but not perfect:

1. add a |src| handler to get js in apps/ instead of build_stage/
2. handle a HTTP GET parameter like original=1 to get script from apps
instead of buid_stage/
3. keep accessing files from apps/ directories....

we can't land the change unless solve this issue.

Julien Wajsberg

unread,
Feb 18, 2014, 4:00:04 AM2/18/14
to Yuren Ju, Axel Hecht, dev-...@lists.mozilla.org
Le 18/02/2014 09:40, Yuren Ju a écrit :
> it will be a problem for unit test workflow that I didn't realize,
> thank you Julien.

Not only unit test, but also when coding in Firefox.

>
> there are some potential solutions but not perfect:
>
> 1. add a |src| handler to get js in apps/ instead of build_stage/

You also need to get images and binaries and everything.

> 2. handle a HTTP GET parameter like original=1 to get script from apps
> instead of buid_stage/

This is not possible, some files are retrieved directly from the app
code. And I'm not sure this would lead to a better httpd.js anyway ;)

> 3. keep accessing files from apps/ directories....

yes :)

>
> we can't land the change unless solve this issue.

I think that even localizers want to run the apps in Firefox and press
"reload" to see their changes.

All this is true only for DEBUG=1 profiles of course. We can try to find
another solution for these use cases but we need to think hard ;)

--
Julien

signature.asc

Axel Hecht

unread,
Feb 18, 2014, 7:30:49 AM2/18/14
to mozilla-...@lists.mozilla.org
Thanks for the ping.

One thing that concerns me is timing. On my machine, the most low-end
DEBUG build takes 10 seconds [1]. That's pretty long for copying a file
from A to B ;-)

I'll write something up about my use case, and my experiences over the
last two weeks in a separate post. They shape much of (the abscense) of
my current thinking, and probably derail this thread too much.

Axel


[1] I consider this to be mostly-minimal:

DEBUG?=1
GAIA_INLINE_LOCALES?=0
GAIA_CONCAT_LOCALES?=0
GAIA_APP_TARGET=production

Kevin Grandon

unread,
Feb 18, 2014, 10:41:17 AM2/18/14
to Yuren Ju, Julien Wajsberg, Axel Hecht, dev-...@lists.mozilla.org
Maybe an option: If you can make the javascript libraries re-useable you can use them in both build/ and the http handler. (The HTTP handler could also be done easily in node as well if this would help). You would still need a few lines of content inside of httpd.js, but it should be fairly minimal.

I have a feeling if you try to load anything from build_stage in httpd you are going to break a lot of workflows.

Best,
Kevin



----- Original Message -----
From: "Yuren Ju" <y...@mozilla.com>
To: "Julien Wajsberg" <jwaj...@mozilla.com>
Cc: "Axel Hecht" <l1...@mozilla.com>, dev-...@lists.mozilla.org
Sent: Tuesday, February 18, 2014 12:40:48 AM
Subject: Re: Remove l10n/shared path handler in httpds.js/bootstrap.js

it will be a problem for unit test workflow that I didn't realize, thank
you Julien.

there are some potential solutions but not perfect:

1. add a |src| handler to get js in apps/ instead of build_stage/
2. handle a HTTP GET parameter like original=1 to get script from apps
instead of buid_stage/
3. keep accessing files from apps/ directories....

we can't land the change unless solve this issue.




On Tue, Feb 18, 2014 at 3:49 PM, Julien Wajsberg <jwaj...@mozilla.com>wrote:

> Le 18/02/2014 08:03, Yuren Ju a écrit :
> > Hi folks,
> >
> > we will copy all apps into build_stage for assembling app, so we will
> > remove l10n and shared directory path handler in httpd.js/bootstrap.js
> and
> > point app directory to build_stage/$APP to get clearer httpd extension.
> >
> > for l10n, we can use |make watch| to monitor files change in gaia and
> > LOCALE_BASEDIR.
> >
> > I will work on it after bug 897352, so please let me know if you have any
> > concern.
> >
>
> How will this work with the "save-reload-test" workflow we're used to
> and rely on? Do we need to keep "make watch" running?
>
>
_______________________________________________
dev-gaia mailing list
dev-...@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-gaia
0 new messages