How to cancel the element picker with keyboard?

[Xue Fuqiao]

Hi list,

I'd like to cancel the "pick an element from the page" action with
keyboard. After searching, I found the following comment in
server/actors/highlighters.js[1]:

/* ESC/CTRL+SHIFT+C: Cancels picker, picks currentNode */

But pressing esc only toggles the split console, and 'cmd/control +
shift + c' doesn't work either (nothing happens). Any idea why?


OS: macOS 10.12
Browsers tried: Firefox 49.0.1 and 52.0a1
(49fe455cac957808ed4a5d1685c3a1938dac1d31)

[1] https://dxr.mozilla.org/mozilla-central/rev/49fe455cac957808ed4a5d1685c3a1938dac1d31/devtools/server/actors/highlighters.js#294

[Tim Nguyen]

Alt+Cmd+C toggles on/off the element picker for me.

[Xue Fuqiao]

On Sun, Oct 9, 2016 at 5:01 AM, Tim Nguyen <nti...@gmail.com> wrote:

Hi Tim,

> On Saturday, October 8, 2016 at 6:34:09 AM UTC+1, Xue Fuqiao wrote:

>> I'd like to cancel the "pick an element from the page" action with
>> keyboard. After searching, I found the following comment in
>> server/actors/highlighters.js[1]:
>>
>> /* ESC/CTRL+SHIFT+C: Cancels picker, picks currentNode */
>>
>> But pressing esc only toggles the split console, and 'cmd/control +
>> shift + c' doesn't work either (nothing happens). Any idea why?
>>
>> OS: macOS 10.12
>> Browsers tried: Firefox 49.0.1 and 52.0a1
>>

>> [1] https://dxr.mozilla.org/mozilla-central/rev/49fe455cac957808ed4a5d1685c3a1938dac1d31/devtools/server/actors/highlighters.js#294
>
> Alt+Cmd+C toggles on/off the element picker for me.

It works for me. Thanks. Do you have any idea why esc doesn't work? In
devtools/server/actors/highlighters.js:

this._onKey = event => {
[...]
switch (event.keyCode) {
[...]
// Cancel pick mode.
case Ci.nsIDOMKeyEvent.DOM_VK_ESCAPE:
this.cancelPick();
events.emit(this._walker, "picker-node-canceled");
return;
[...]

The code looks good to me. Why/How does the split console capture this event?

[Patrick Brosset]

Ctrl+Shift+C works for me (tested on windows FF51). Could you file a bug if
it doesn't for you?
https://bugzilla.mozilla.org/enter_bug.cgi?product=Firefox&component=Developer%20Tools%3A%20Inspector
Escape indeed doesn't work, I think Greg Tatum was working on fixing this,
although I can't remember which bug he was doing the work in (the problem
is that the content window doesn't receive focus, so escape is handled by
the toolbox, which is why the split console opens up).

On Sat, Oct 8, 2016 at 7:33 AM, Xue Fuqiao <xfq....@gmail.com> wrote:

> Hi list,

>
> I'd like to cancel the "pick an element from the page" action with
> keyboard. After searching, I found the following comment in
> server/actors/highlighters.js[1]:
>
> /* ESC/CTRL+SHIFT+C: Cancels picker, picks currentNode */
>
> But pressing esc only toggles the split console, and 'cmd/control +
> shift + c' doesn't work either (nothing happens). Any idea why?
>
>
> OS: macOS 10.12
> Browsers tried: Firefox 49.0.1 and 52.0a1

> (49fe455cac957808ed4a5d1685c3a1938dac1d31)
>
> [1] https://dxr.mozilla.org/mozilla-central/rev/
> 49fe455cac957808ed4a5d1685c3a1938dac1d31/devtools/server/
> actors/highlighters.js#294
> _______________________________________________
> dev-developer-tools mailing list
> dev-devel...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-developer-tools
>

[Xue Fuqiao]

On Mon, Oct 10, 2016 at 3:11 PM, Patrick Brosset <pbro...@mozilla.com> wrote:

Hi Patrick,

> Ctrl+Shift+C works for me (tested on windows FF51). Could you file a bug if
> it doesn't for you?
> https://bugzilla.mozilla.org/enter_bug.cgi?product=Firefox&component=Developer%20Tools%3A%20Inspector

As Tim said, in macOS, cmd+option+c should be used (and it works for
me). So there is no need for the bug report.

> Escape indeed doesn't work, I think Greg Tatum was working on fixing this,
> although I can't remember which bug he was doing the work in (the problem is
> that the content window doesn't receive focus, so escape is handled by the
> toolbox, which is why the split console opens up).

I see. Thank you!

[Greg Tatum]

Yes, this is a focus issue when the toolbar is docked. I'm working on this
here: https://bugzilla.mozilla.org/show_bug.cgi?id=1224304