[devtools-rfcs]

[Greg Tatum]

*Code Review Policy in DevTools*

https://github.com/devtools-html/rfcs/issues/41

This RFC is a follow-up with #37
<https://github.com/devtools-html/rfcs/issues/37>.

It would be nice to re-visit our code review practices, and update our internal
documentation <http://docs.firefox-dev.tools/contributing/code-reviews.html>.
Right now we have a checklist to specific issues to look for, which can be
helpful for new contributors, but we don't address *why* we do code
reviews. I think we are missing a higher level policy document.

I personally think this is really important discussion to have as a group,
because every day we have the code that we spent our time, passion, and
energy on criticized by our peers. This is really important for writing
high quality code, but it can be a difficult part of our jobs as we are
personally invested in our little diffs of code. In addition, as a really
distributed team, it's easy to lack empathy with each other when all you
are presented with is a list of issues to fix from a glowing screen.

@jryans <https://github.com/jryans> shared "How to Do Code Reviews Like a
Human <https://mtlynch.io/human-code-reviews-1/>", and I also did some of
my own research for different recommendations. I'm going to try and
summarize some specific recommendations with headlines, and include a
snippet of support from various articles. Feel free to skim the quotes and
focus on the headlines, although I would recommend reading the full
articles.
View the rest of the RFC on GitHub.
<https://github.com/devtools-html/rfcs/issues/41>