[devtools-rfcs] Discussion about DEBUG_JS_MODULES and DEBUG

[Julian Descottes]

A new proposal has been posted on https://github.com/devtools-html/rfcs

subject: Discussion about DEBUG_JS_MODULES and DEBUG
link: https://github.com/devtools-html/rfcs/issues/36

> DEBUG_JS_MODULES is enabled by a line in mozconfig:
>
> ac_add_options --enable-debug-symbols
>
> while DEBUG is enabled by a similar line:
>
> ac_add_options --enable-debug
>
> DEBUG_JS_MODULES was intended to run some of our code in a "debug" mode
but
> still using a Firefox production build, so much faster. Most of our code
that
> uses DEBUG_JS_MODULES also checks for DEBUG. The direct result is that
gecko
> developers running a DEBUG build without DEBUG_JS_MODULES also gets the
same
> performance penalty.
>
> One direct effect of DEBUG_JS_MODULES is that we load the dev versions of
> react and other libraries, which are also a lot slower. As said
previously,
> this happens also for simple DEBUG builds.
>
> So there are a few questions to answer about it:
>
> Does running the dev version of react help anybody in the team?
> If yes, should we uncouple DEBUG and DEBUG_JS_MODULES? That would mean
> that DEBUG wouldn't trigger the dev versions of 3rd-party libraries
> anymore, we'd have to specify DEBUG_JS_MODULES explicitely. I think
this
> would be a good thing.
> If no, should we remove the full support for DEBUG_JS_MODULES? This is
> the good approach if nobody uses it.
>

Comment on the GitHub issue if you want to join the conversation!