Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

"good first bug" and test cases

6 views
Skip to first unread message

Hallvord Reiar Michaelsen Steen

unread,
Oct 6, 2015, 4:12:44 PM10/6/15
to dev-developer-tools
Hi,
in the context of https://bugzilla.mozilla.org/show_bug.cgi?id=1108042
(although looking at the patch I'm not sure if the person who attempted to
fix it understood the problem): some contributor started working on a bug
classified as good-first-bug, attached a patch, got some feedback. So far
so good, but the feedback basically said "needs a test case".

I've found that writing a test is a much steeper learning curve than
actually fixing the source code. It may be getting easier with Task.async()
and yield, but it's still not IMHO a newbie-friendly task. I'm not saying
this to single out fitzgen and say it was a bad review, but I'd like to
take this opportunity to suggest that mentors should offer to write test
cases and/or attach test cases to some good-first-bug bugs before they are
even labelled as such.
-Hallvord
0 new messages