[BUG?] Repeated conditional tests, LazyBSONObject.java

[Eun-Jeong Shin]

Hi, all.

While I was testing project via "FindBugs", I got this error message as below. 

Could you take a look?

File name : LazyBSONObject.java

Line # : 173

Source : below line is repetitive.

binaryType == BsonBinarySubType.BINARY.getValue()

Message : 

***driver/src/main/org/bson/LazyBSONObject.java:173 Repeated conditional test in org.bson.LazyBSONObject.readValue(BsonBinaryReader) [Scary(8), Normal confidence]

[Ross Lawley]

Hi,

Thanks again! I'm fixing as part of the wider findbugs review (https://jira.mongodb.org/browse/JAVA-1823). Findbugs 3.0.0 missed this but upgrading to 3.0.1 triggers it so upgrading as part of our test suite.

Seems the cause was automated refactoring during the code base changes from 2.x series to 3.x

Ross

[Eun-Jeong Shin]

Thank you! Glad that this suggestion is accepted!