dedup_inlined_images filter not filling up all duplicate images

[mick...@kikuta2008.com]

Hi there,

We started using dedup_inlined_images and there are cases it doesn't fill all the images (see attached screenshot below). From what I have seen it's it happens when the page is opened in a new tab, but I couldn't reproduce it all the times.

[mick...@kikuta2008.com]

We recreated the problem without opening a link on new tab. This time the web developer window was on and we captured network communication.

It seems the images are requested, but not properly populated, take a look at the screenshot. Note that the console does not show any errors.

[Joshua Marantz]

I agree.  I am not certain, but it also looks broken on http://modpagespeed.com/dedup_inlined_images.html?ModPagespeed=on&ModPagespeedFilters=inline_images,dedup_inlined_images .

Tracking on https://github.com/pagespeed/mod_pagespeed/issues/1369

--
You received this message because you are subscribed to the Google Groups "mod-pagespeed-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mod-pagespeed-di...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/mod-pagespeed-discuss/e986aee3-3b14-4d21-8e5c-f3efb636ed32%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

[Mickey]

Say, any chance to release a minor version with fixes?

Including this one we have two fixes waiting for us on the git.

You received this message because you are subscribed to a topic in the Google Groups "mod-pagespeed-discuss" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/mod-pagespeed-discuss/ZlpKH_1O3A4/unsubscribe.
To unsubscribe from this group and all its topics, send an email to mod-pagespeed-di...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/mod-pagespeed-discuss/CAGKR%2BECe%2BGn0eVK4a36KRVLnNiuHdsoDi-a34xkwb%3DrnmpTexg%40mail.gmail.com.

[Joshua Marantz]

We have a tracking bug but no solution as of yet for this problem.

We are in fact trying to get a bug-fix release ready, but I don't expect it to fix dedup_inlined_images.

For now, can you disable the filter?

To view this discussion on the web visit https://groups.google.com/d/msgid/mod-pagespeed-discuss/35099a68-17ad-01fd-9a4b-2025d1c11f47%40kikuta2008.com.

[Mickey]

> We are in fact trying to get a bug-fix release ready

Great news :-D

> I don't expect it to fix dedup_inlined_images

Is there any chance to squeeze this fix in, or is it a serious one? I'm asking as it's reproducible on your environment which may make it easier to fix.

> For now, can you disable the filter?

If need be, yes.

This way or that, thanks for all the support. You guys are doing a great job!

To view this discussion on the web visit https://groups.google.com/d/msgid/mod-pagespeed-discuss/CAGKR%2BEBUx53Yxk2gV%3D%3Dya-1CCO0c-6FmMvoytN-8za2w37%2BaRQ%40mail.gmail.com.