refactoring

[Mo Morsi]

Previously on Omega....

https://github.com/movitto/omega/blob/4082c328ce388c258321d08c1895aa7622805076/site/source/javascripts/pages/index.js

...

When suddently a commit happens!

https://github.com/movitto/omega/commit/4082c328ce388c258321d08c1895aa7622805076


...

Now:

https://github.com/movitto/omega/blob/6ead5fe888e38e7d4a703511842aff7c9c9a4885/site/source/javascripts/pages/index.js

...


old lines: 457
new lines: 112
reduced: 75.49% !

Refactoring FTW! :-)

For those that are wondering the fuctionality is still there but split
out into seperate / more maintainable and reusable modules:

https://github.com/movitto/omega/blob/master/site/source/javascripts/ui/loader.js
https://github.com/movitto/omega/blob/master/site/source/javascripts/ui/tracker.js
https://github.com/movitto/omega/blob/master/site/source/javascripts/ui/canvas_tracker.js
https://github.com/movitto/omega/blob/master/site/source/javascripts/ui/session_validator.js

Each of these JS classes can be independantly included in Page classes
or any others, immediately making that functionaliy available for use there.

-Mo

[Mo Morsi]

On 01/19/2014 10:55 AM, Mo Morsi wrote:
> ...
>
> When suddently a commit happens!
>
> https://github.com/movitto/omega/commit/4082c328ce388c258321d08c1895aa7622805076

Arg wrong commit :-/

https://github.com/movitto/omega/commit/6ead5fe888e38e7d4a703511842aff7c9c9a4885


-Mo

[Nicolas Satragno]

That's what I call serious refactoring!

Nicolás Satragno <nsat...@gnome.org>

--
You received this message because you are subscribed to the Google Groups "omega" group.
To unsubscribe from this group and stop receiving emails from it, send an email to omegaverse+...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Mo Morsi]

On 01/19/2014 10:58 AM, Nicolas Satragno wrote:

That's what I call serious refactoring!

It wasn't too bad, most of the logic split up easily around the procedures already in the index page js. Tried to come up w/ semantically fitting names and split it slightly differently (very slighly) so that the methods in each module fit the purpose of the module. This way other pages can include these without much fuss.

/me may have cheated a little and committed code before he wrote tests

http://blog.omegaverse.info/images/test.jpg

(will update them momentarily)

  -Mo

[Mo Morsi]

On 01/19/2014 11:08 AM, Mo Morsi wrote:

(will update them momentarily)

  -Mo

Updated:

https://github.com/movitto/omega/commit/53517682e36382bb8bba86e329118f2424b237c4

  -Mo