[Midnight Commander] #3658: Subshell not working with Bourne shell /bin/sh (not bash)

40 views
Skip to first unread message

Ticket System

unread,
Jun 26, 2016, 7:53:41 AM6/26/16
to wood...@gmail.com, mc-...@googlegroups.com
#3658: Subshell not working with Bourne shell /bin/sh (not bash)
--------------------------------+-------------------------------
Reporter: woodsb02 | Type: defect
Status: new | Priority: major
Milestone: Future Releases | Component: mc-core
Version: master | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
--------------------------------+-------------------------------
The subshell is not working with the Bourne shell /bin/sh, specifically in
my case on FreeBSD. Note this is different to BASH.

When mc has been compiled with subshell support, and started in the Bourne
shell, it fails to start with the following error message
{{{
common.c: unimplemented subshell type 1
read (subshell_pty...): No error: 0 (0)
}}}

Note that this error message occurs when mc starts - not afterwards when
trying to view the subshell with ctrl+o.

The FreeBSD bug for this is
[https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208391 PR 208391]

--
Ticket URL: <http://www.midnight-commander.org/ticket/3658>
Midnight Commander <http://www.midnight-commander.org>
Midnight Development Center

Ticket System

unread,
Jun 26, 2016, 7:56:38 AM6/26/16
to wood...@gmail.com, mc-...@googlegroups.com
#3658: Subshell not working with Bourne shell /bin/sh (not bash)
--------------------------+---------------------------------------
Reporter: woodsb02 | Owner:

Type: defect | Status: new
Priority: major | Milestone: Future Releases
Component: mc-core | Version: master
Resolution: | Keywords:

Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
--------------------------+---------------------------------------

Comment (by woodsb02):

The attached patch allows mc to start without error. However, there is a 5
second delay when it starts. When trying to use the subshell, it simply
shows a blank terminal, at which point any key press returns you to the
normal mc file layout screen.

--
Ticket URL: <http://www.midnight-commander.org/ticket/3658#comment:1>

Ticket System

unread,
Jul 1, 2016, 4:03:04 PM7/1/16
to wood...@gmail.com, mc-...@googlegroups.com
#3658: Subshell not working with Bourne shell /bin/sh (not bash)
--------------------------+---------------------------------------
Reporter: woodsb02 | Owner:

Type: defect | Status: new
Priority: major | Milestone: Future Releases
Component: mc-core | Version: master
Resolution: | Keywords:

Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
--------------------------+---------------------------------------

Comment (by and):

Confirm on Solaris Bourne shell.

But subshell will never work on sh because precmd() comparable feature
(for signaling current PWD back to mc) is missing.

--
Ticket URL: <http://www.midnight-commander.org/ticket/3658#comment:2>

Ticket System

unread,
Sep 24, 2016, 2:22:57 PM9/24/16
to wood...@gmail.com, mc-...@googlegroups.com
#3658: Subshell not working with Bourne shell /bin/sh (not bash)
--------------------------+---------------------------------------
Reporter: woodsb02 | Owner:

Type: defect | Status: new
Priority: major | Milestone: Future Releases
Component: mc-core | Version: master
Resolution: | Keywords:

Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
--------------------------+---------------------------------------

Comment (by andrew_b):

Ticket #3689 has been marked as a duplicate of this ticket.

--
Ticket URL: <http://www.midnight-commander.org/ticket/3658#comment:3>

Ticket System

unread,
Oct 24, 2016, 8:50:43 AM10/24/16
to wood...@gmail.com, mc-...@googlegroups.com
#3658: Subshell not working with Bourne shell /bin/sh (not bash)
--------------------------+---------------------------------------
Reporter: woodsb02 | Owner:

Type: defect | Status: new
Priority: major | Milestone: Future Releases
Component: mc-core | Version: master
Resolution: | Keywords:
Blocked By: 3692 | Blocking:

Branch state: no branch | Votes for changeset:
--------------------------+---------------------------------------

Comment (by sierkb):

Confirm on macOS 10.12.0 (Sierra).
See also [https://www.macports.org/ MacPorts] ticket
[https://trac.macports.org/ticket/52511 #52511 – mc: subshell not working
with /bin/sh] incl. comments.

Please fix and release. And please target for next possible release or bug
fix release instead for any undefined future release, so that patches
relating this issue can take effect as soon as possible on the user's
side.

--
Ticket URL: <http://www.midnight-commander.org/ticket/3658#comment:5>

Ticket System

unread,
Oct 24, 2016, 4:15:32 PM10/24/16
to wood...@gmail.com, mc-...@googlegroups.com
#3658: Subshell not working with Bourne shell /bin/sh (not bash)
--------------------------+---------------------------------------
Reporter: woodsb02 | Owner:

Type: defect | Status: new
Priority: major | Milestone: Future Releases
Component: mc-core | Version: master
Resolution: | Keywords:
Blocked By: 3692 | Blocking:

Branch state: no branch | Votes for changeset:
--------------------------+---------------------------------------

Comment (by zaytsev):

Fix and release what? Do you know of a way to support Bourne shell?
Otherwise, if you want to use Bourne shell, you have to start mc without
subshell. I can't see what can be done here...

--
Ticket URL: <http://www.midnight-commander.org/ticket/3658#comment:6>

Ticket System

unread,
Feb 17, 2017, 3:56:03 PM2/17/17
to wood...@gmail.com, mc-...@googlegroups.com
#3658: Subshell not working with Bourne shell /bin/sh (not bash)
--------------------------+---------------------------------------
Reporter: woodsb02 | Owner:

Type: defect | Status: new
Priority: major | Milestone: Future Releases
Component: mc-core | Version: master
Resolution: | Keywords:
Blocked By: 3692 | Blocking:

Branch state: no branch | Votes for changeset:
--------------------------+---------------------------------------

Comment (by willbproggin):

Replying to [comment:6 zaytsev]:


> Fix and release what? Do you know of a way to support Bourne shell?
Otherwise, if you want to use Bourne shell, you have to start mc without
subshell. I can't see what can be done here...

This affects me [https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208391
on FreeBSD] as well. Can mc be fixed to just start internally without
subshell support if it can't support a shell instead of failing
ungracefully?

--
Ticket URL: <http://www.midnight-commander.org/ticket/3658#comment:7>

Ticket System

unread,
Jul 25, 2017, 2:16:09 PM7/25/17
to wood...@gmail.com, mc-...@googlegroups.com
#3658: Subshell not working with Bourne shell /bin/sh (not bash)
--------------------------+------------------------------
Reporter: woodsb02 | Owner:
Type: defect | Status: closed
Priority: major | Milestone:
Component: mc-core | Version: master
Resolution: duplicate | Keywords:
Blocked By: 3692 | Blocking:

Branch state: no branch | Votes for changeset:
--------------------------+------------------------------
Changes (by andrew_b):

* status: new => closed
* resolution: => duplicate
* milestone: Future Releases =>


Comment:

Closed as duplicate of #373.

--
Ticket URL: <http://www.midnight-commander.org/ticket/3658#comment:8>

Reply all
Reply to author
Forward
0 new messages