New developer's version: Marpa-R2 2.079_001

[Jeffrey Kegler]

I've just uploaded Marpa-R2 2.079_001, a developer's release.  A lot of internal refactoring, but no real externally-visible value added.

The purpose of the release is the help me make sure that all my refactoring has not broken portability or installation.  As usual, those who are willing to take on a new developer's version (even one with no new features) and test it are much appreciated.

-- jeffrey

[Ron Savage]

Counts: Tests: 542. Modules: 8. Passes: 8. Fails: 0

Elapsed time: 1 minute and 28 seconds

Hmm, really should output Marpa's version #.

[Ruslan Shvedov]

Everything's ok on cygwin; compile error on windows (cl 13.10.3077, .net 2003).

cl -c    -nologo -GF -W3 -MD -Zi -DNDEBUG -O1 -DWIN32 -D_CONSOLE -DNO_STRICT -DPERL_TEXTMODE_SCRIPTS -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DUSE_PERLIO -D_USE_32BIT_TIME_T -DPERLDLL -MD -Zi -DNDEBUG -O1    -DVERSION=\"5.179.101\"  -DXS_VERSION=\"5.179.101\"  "-IC:\perl-5.14.2\lib\CORE"   marpa_codes.c

marpa_codes.c

./marpa_ami.w(495) : error C2054: expected '(' to follow 'inline'

./marpa_ami.w(495) : error C2085: 'marpa_dstack_resize2' : not in formal parameter list

./marpa_ami.w(496) : error C2082: redefinition of formal parameter 'inline'

./marpa_ami.w(496) : error C2143: syntax error : missing ';' before 'type'

./marpa_ami.w(496) : error C2085: 'marpa_dstack_resize' : not in formal parameter list

./marpa_ami.w(498) : error C2005: #line expected a line number, found 'string'

./marpa_ami.w(502) : error C2005: #line expected a line number, found 'string'

./marpa_ami.w(506) : error C2005: #line expected a line number, found 'string'

./marpa_ami.w(509) : error C2005: #line expected a line number, found 'string'

./marpa_ami.w(512) : error C2082: redefinition of formal parameter 'inline'

./marpa_ami.w(512) : error C2143: syntax error : missing ';' before 'type'

./marpa_ami.w(513) : error C2085: 'my_free' : not in formal parameter list

./marpa_ami.w(513) : error C2143: syntax error : missing ';' before '{'

./marpa_ami.w(206) : error C2054: expected '(' to follow 'inline'

./marpa_ami.w(207) : error C2085: 'my_malloc' : not in formal parameter list

./marpa_ami.w(207) : error C2143: syntax error : missing ';' before '{'

./marpa_ami.w(214) : error C2054: expected '(' to follow 'inline'

./marpa_ami.w(216) : error C2085: 'my_malloc0' : not in formal parameter list

./marpa_ami.w(216) : error C2143: syntax error : missing ';' before '{'

./marpa_ami.w(223) : error C2054: expected '(' to follow 'inline'

./marpa_ami.w(225) : error C2085: 'my_realloc' : not in formal parameter list

./marpa_ami.w(225) : error C2143: syntax error : missing ';' before '{'

./marpa_ami.w(316) : error C2054: expected '(' to follow 'inline'

./marpa_ami.w(317) : error C2085: 'marpa_dstack_resize2' : not in formal parameter list

./marpa_ami.w(317) : error C2143: syntax error : missing ';' before '{'

./marpa_ami.w(325) : error C2054: expected '(' to follow 'inline'

./marpa_ami.w(328) : error C2085: 'marpa_dstack_resize' : not in formal parameter list

./marpa_ami.w(328) : error C2143: syntax error : missing ';' before '{'

build log attached.

--
You received this message because you are subscribed to the Google Groups "marpa parser" group.
To unsubscribe from this group and stop receiving emails from it, send an email to marpa-parser...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Jeffrey Kegler]

I think I've identified this issue.  The "inline" keyword is not provided natively by the Windows compiler, and is not being defined correctly by Marpa because I'm not including autoconf's "config.h" where I should.  I'll attempt a fix in the next developer's release.

-- jeffrey

[Ruslan Shvedov]

On Wed, Jan 1, 2014 at 3:41 PM, Jeffrey Kegler <jeffre...@jeffreykegler.com> wrote:

I think I've identified this issue.  The "inline" keyword is not provided natively by the Windows compiler, and is not being defined correctly by Marpa because I'm not including autoconf's "config.h" where I should. 

Looks like inline is missing from c90 [1] and is supported by GNU C [2] and MS C [3] via alternate keywords.

I'll attempt a fix in the next developer's release.

Great, I'd be happy to help with testing. 

[1] http://stackoverflow.com/questions/12151168/does-ansi-c-not-know-the-inline-keyword

6.7.4 Function specifiers — http://www.coding-guidelines.com/cbook/c90c++.pdf

[2] http://gcc.gnu.org/onlinedocs/gcc/Inline.html

[3] http://en.wikipedia.org/wiki/Inline_function#Microsoft_Visual_C.2B.2B_specific

-- jeffrey

On 01/01/2014 03:14 AM, Ruslan Shvedov wrote:

Everything's ok on cygwin; compile error on windows (cl 13.10.3077, .net 2003).

[Jeffrey Kegler]

What's going on is that I am using autoconf's AC_C_INLINE to make sure that, if "inline" does not exist natively, that it is defined to a substitute ("__inline__") if possible.  If there's just no way the compiler does inlining, then AC_C_INLINE defines "inline" as null.  AC_C_INLINE's "fix" goes into a header named "config.h".  (On some systems Marpa uses Config::AutoConf, which Jean-Damien set up for me, instead of GNU's autoconf, to accomplish the same thing.)

My mistake (I believe) was very simple: I did include "config.h" in one place where it was needed.

-- jeffrey

[Ruslan Shvedov]

Ok, got it, thanks for explaining.