Re: [hypervm] Fixed #1059 and Login Page redesign (#57)

[Danny Terweij | LxCenter]

* Moved from github.

Op 25-9-2013 17:22, semirke schreef:
>
> In hypervm/httpdocs/img/loginskin/login_page.css:
>
> > @@ -0,0 +1,81 @@
> > +body {
> > + margin: 0px;
> > + padding: 0px;
> > + color: #333;
> > + background: url(/img/loginskin/polaroid/polaroid.png) repeat;
>
> Danny,
>
> I do not think moving things together will make the project less
> scattered.
> There are and there should be the place for every kind of files we
> use. like I used the image directory to store the image. I put the css
> file there only because Im thinking about letting the user change the
> skin. Which could be easily done by changing loginskin directory to a
> symlink.
>
> Other than that, moving code together fits my opinion. Do you agree?
>

I think all should be at one place, think forward. A theme/skin, in
whatever app you look, had its own dir and from there a standard structure.

We have a dir named /login/ from there the loginpage is started.
Now it loads many from different places.

So make /login/themes/default
.*.html pages
*.php pages
./css
./img

Everything at one place with a structure.

Symlinking is not the way. Ugly.
Just use /login/themes/someother/

You might can do it statictly for the moment, from the main index, set a
variable $loginTheme="default";
Or do it right at once and make a login theme selection at the
Apeariance (that word has a typo hehe) page.

When all files scattererd then skinning is not easy to do for the user.
Make it easy for them.

Danny

[András Otártics]

2013/9/25 Danny Terweij | LxCenter <d.te...@lxcenter.org>

Refactoring XD The whole thing should be refactored according to the Model-View-Controller structure... 

But as that is not something we will pull out, I would say I agree with you.

However, I do not see your point globally. I mean I see and think it is OK with the login page, but is it also a new way in structuring the future pages? 

Whenever I used any pre-created frameworks, I saw they tend to group things that belong by type (MVC).

Of course, some things, like plugins have their full separate structures. 

But when working with pages, you always know where to find them. 

Perhaps better file naming? (Like I'll commit the login pages soon.)

 

 

--
You received this message because you are subscribed to the Google Groups "LxCenter Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to lxdevel+unsubscribe@googlegroups.com.
To post to this group, send email to lxd...@googlegroups.com.
Visit this group at http://groups.google.com/group/lxdevel.
To view this discussion on the web visit https://groups.google.com/d/msgid/lxdevel/52433080.60204%40lxcenter.org.
For more options, visit https://groups.google.com/groups/opt_out.

--
Otártics András
Villamosmérnök
Telefon: +3620-503-96-11
E-mail: otart...@gmail.com

[Walter Secco]

Just adding something to the discussion before I forget. Error/Alert
messages should be hardcoded otherwise you can do fun things like
this:

http://insert.your.hypervm.ip.here:8888/login/?frm_emessage=Your%20account%20has%20been%20suspended.%20Please%20e-mail%20your%20credit%20card%20number%20to%20sc...@scam.com.

A real scammer would be more convincing though. :)

Same goes for Kloxo.

>> email to lxdevel+u...@googlegroups.com.

>> To post to this group, send email to lxd...@googlegroups.com.
>> Visit this group at http://groups.google.com/group/lxdevel.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/lxdevel/52433080.60204%40lxcenter.org.
>> For more options, visit https://groups.google.com/groups/opt_out.
>
>
>
>
> --
> Otártics András
> Villamosmérnök
> Telefon: +3620-503-96-11
> E-mail: otart...@gmail.com
>

> --
> You received this message because you are subscribed to the Google Groups
> "LxCenter Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an

> email to lxdevel+u...@googlegroups.com.

> To post to this group, send email to lxd...@googlegroups.com.
> Visit this group at http://groups.google.com/group/lxdevel.
> To view this discussion on the web visit

> https://groups.google.com/d/msgid/lxdevel/CA%2Bhz3RJzcOrvC21cEbvfw650Ww8qYD9Cji2OU9vOF6gY3HAFrg%40mail.gmail.com.

[András Otártics]

2013/9/25 Walter Secco <wal...@neue.com.br>

Just adding something to the discussion before I forget. Error/Alert
messages should be hardcoded otherwise you can do fun things like
this:

http://insert.your.hypervm.ip.here:8888/login/?frm_emessage=Your%20account%20has%20been%20suspended.%20Please%20e-mail%20your%20credit%20card%20number%20to%20sc...@scam.com.

A real scammer would be more convincing though. :)

 Nope, I almost bought it ;)

 And I start to get the feeling that we are standing on the top of the iceberg XD

 Walter, please comment on the original discussion, too.

 

To view this discussion on the web visit https://groups.google.com/d/msgid/lxdevel/CANX5KgnQb9Vtd6Kv6tRt6SDDkeu32gzOB1GeY0W3-Uc61zDTTw%40mail.gmail.com.

For more options, visit https://groups.google.com/groups/opt_out.