HTTP basic authentication not working in 2.5

[Ugo Bataillard]

Hello everyone,

When switching to Lift 2.5 my basic http authentication doesn't happen anymore and I have no idea why. I just switched back to 2.4 to confirm that it doesn't come from anything else and this is the case.
Here is my code:

LiftRules.httpAuthProtectedResource.prepend {
       case Req("api"::"post"::_, _, PostRequest) => Full(AuthRole("user"))
}

LiftRules.authentication = HttpBasicAuthentication("api") {
            case (username, password, req) => {
                authService.login(username,password) match {
                    case Full(user) => {
                        userRoles(AuthRole("user"))
                        true
                    }
                    case _ => {
                        false
                    }
                }
            }
        }

Thank you in advance

Ugo

[Diego Medina]

Could you post a sample app showing this? Later tonight a can track down which change in lift broke this (please see the signature on this email for instructions).
Thanks

Diego

Diego
Sent from my android cell

--
--
Lift, the simply functional web framework: http://liftweb.net
Code: http://github.com/lift
Discussion: http://groups.google.com/group/liftweb
Stuck? Help us help you: https://www.assembla.com/wiki/show/liftweb/Posting_example_code
 
 
 

[Ugo Bataillard]

Hi Diego,
Thank you for your quick answer, I'll try that this afternoon.

[Diego Medina]

On Wed, Sep 26, 2012 at 9:15 PM, Ugo Bataillard <u...@bataillard.me> wrote:
> Hi Diego,
> Thank you for your quick answer, I'll try that this afternoon.

Thanks

Diego Medina
Lift/Scala Developer
di...@fmpwizard.com
http://www.fmpwizard.com

[Ugo Bataillard]

Here it is :
https://github.com/knshiro/lift-2.5-httpauthentication-broken

[Diego Medina]

I started working on this, if I don;t reply by wednesday, feel free to
send me a reminder. (While we normally discourage nagging, I really
want to get this fixed before 2.5-M2)

Thanks

Diego

[Ugo Bataillard]

No worries, I will.
Thank you very much for your support !

Ugo

[Diego Medina]

Good news and bad news. Good news I didn't break this with the commit I thought.
Bad news is that I went back 7 month in history and this was still broken.

Now I'm trying a new approach to finding the solution.

Thanks

Diego
Sent from my android cell

[Diego Medina]

Ok, more results (no solution though).

If the browser sends the Authentication data, Lift routes the request
the right way, but for some reason, it does not send a 401 in the
first place (so the browser would ask you for a username/password.
I'll continue to look to see what changed in 2.5 that could cause this.

But in the meantime, you can go ahead and enter a bug at
ticket.liftweb.net and assign it to me. Add a note linking this
thread, so we have a reference.

Thanks

Diego

[Ugo Bataillard]

Thank you very much for your time Diego, I'll fill a bug then.

Ugo

[Diego Medina]

Thanks to Aditya, it is now fixed

https://github.com/lift/framework/issues/1330

it should be in snapshot in a few hours

Thanks

Diego