S.redirectTo with Non-ASCII Chars

[Ben Phelan]

S.redirectTo doesn't seem to work with non-ascii characters, although I haven't been able to figure out why so far.

For example, when calling S.redirectTo("/ß") the browser is redirected to /%DF instead of /%C3%9F.  There doesn't seem to be any problem with encJs("/ß") == "/\u00df" and throwing a raw <script>window.location = "/\u00df";</script> into a template gives the desired result.  So I'm guessing my issue has something to do with URLRewriter?

Is there a setting somewhere that would resolve this or some other simple way to get this working?

Cheers,

Ben

[David Pollak]

On Thu, Mar 15, 2012 at 3:35 AM, Ben Phelan <bem...@gmail.com> wrote:

S.redirectTo doesn't seem to work with non-ascii characters, although I haven't been able to figure out why so far.

For example, when calling S.redirectTo("/ß") the browser is redirected to /%DF instead of /%C3%9F.  There doesn't seem to be any problem with encJs("/ß") == "/\u00df" and throwing a raw <script>window.location = "/\u00df";</script> into a template gives the desired result.  So I'm guessing my issue has something to do with URLRewriter?

URLRewriter is used for re-writing incoming requests.  It has nothing to do with outgoing requests.

It's likely something in the container.  S.redirectTo turns into:

/**

 * 301 Redirect.

 */

case class PermRedirectResponse(uri: String, request: Req, cookies: HTTPCookie*) extends LiftResponse {

  def toResponse = InMemoryResponse(Array(), List("Location" -> uri), cookies.toList, 301)

}

/**

 * 307 Redirect.

 */

case class TemporaryRedirectResponse(uri: String, request: Req, cookies: HTTPCookie*) extends LiftResponse {

  def toResponse = InMemoryResponse(Array(), List("Location" -> uri), cookies.toList, 307)

}

The only thing going on here is setting the Location header to the uri.  I'm betting the location header conversion stuff is not done with the correct character encoding by whatever containers you're using.  For kicks, try adding a header "X-FooBar" with the value "/ß" and see what comes out the other side.

 

Is there a setting somewhere that would resolve this or some other simple way to get this working?

Cheers,

Ben

--
Lift, the simply functional web framework: http://liftweb.net
Code: http://github.com/lift
Discussion: http://groups.google.com/group/liftweb
Stuck? Help us help you: https://www.assembla.com/wiki/show/liftweb/Posting_example_code

--

Visi.Pro, Cloud Computing for the Rest of Us http://visi.pro

Lift, the simply functional web framework http://liftweb.net

Follow me: http://twitter.com/dpp
Blog: http://goodstuff.im

[Ben Phelan]

Thanks David!  My 3am code-tracing skills obviously need some work. :)

I can't find anything anywhere about fixing the issue at the container level with Jetty 6, 7 or 8.  The simplest solution seems to be to just S.redirectTo("/' + URLEncoder.encode("non-ascii string", "UTF-8")).

Cheers,

Ben

[David Pollak]

On Thu, Mar 15, 2012 at 3:16 PM, Ben Phelan <bem...@gmail.com> wrote:

Thanks David!  My 3am code-tracing skills obviously need some work. :)

Asking questions like yours is what this list is here for.

 

I can't find anything anywhere about fixing the issue at the container level with Jetty 6, 7 or 8.  The simplest solution seems to be to just S.redirectTo("/' + URLEncoder.encode("non-ascii string", "UTF-8")).

That's really ugly.  Can you open a ticket on this issue?  I'll put the conversion to UTF-8 in the header stuffing code.

 

Cheers,

Ben

--
Lift, the simply functional web framework: http://liftweb.net
Code: http://github.com/lift
Discussion: http://groups.google.com/group/liftweb
Stuck? Help us help you: https://www.assembla.com/wiki/show/liftweb/Posting_example_code

[Ben Phelan]

Ok, will post a ticket (to github, one assumes) when I get a minute.

Thanks David.

[Ben Phelan]

Opened issue: https://github.com/lift/framework/issues/1245