Add "csv" to known suffixes
26 views
Skip to first unread message
j...@joescii.com
Oct 11, 2017, 10:14:39 AM10/11/17
to Lift
One of my clients hit an issue trying to access a csv file served from Lift. It turns out that it was not among our list of known suffixes. PR opened: https://github.com/lift/framework/pull/1922
Any concerns?
Joe
Richard Dallaway
Oct 11, 2017, 10:29:17 AM10/11/17
to Lift
It might be a breaking change, worthy of a note someplace.
Anyone implementing a REST-style service that expects to receive the full csv filename will no-longer receive the .csv part. e.g, something like...
serve {
case "download" :: filename :: Nil Get req =>
// filename was "foo.csv" and will become "foo" here after the change
}
I think. Maybe.
If that's true, the workaround (after the change) is LiftRules.explicitlyParsedSuffixes = Helpers.knownSuffixes - "csv" in boot.
Richard
--
--
Lift, the simply functional web framework: http://liftweb.net
Code: http://github.com/lift
Discussion: http://groups.google.com/group/liftweb
Stuck? Help us help you: https://www.assembla.com/wiki/show/liftweb/Posting_example_code
---
You received this message because you are subscribed to the Google Groups "Lift" group.
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+u...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Diego Medina
Oct 11, 2017, 11:11:31 AM10/11/17
to Lift
If that's true, the workaround (after the change) is LiftRules.explicitlyParsedSuffixes = Helpers.knownSuffixes - "csv" in boot.
I much rather have someone who needs csv to update their LiftRules than someone who updates Lift versions later on find out their app broke.
The way I see it, if a feature doesn't work while you are developing it, you have more time to find out what the problem is, vs the risk of your test not testing the csv extension and after upgrading lift, customers of your app start to
complain their file uploads stopped working.
Regards,
Diego
Richard
On Wed, 11 Oct 2017 at 15:14 <j...@joescii.com> wrote:
One of my clients hit an issue trying to access a csv file served from Lift. It turns out that it was not among our list of known suffixes. PR opened: https://github.com/lift/framework/pull/1922--Any concerns?Joe
--
Lift, the simply functional web framework: http://liftweb.net
Code: http://github.com/lift
Discussion: http://groups.google.com/group/liftweb
Stuck? Help us help you: https://www.assembla.com/wiki/show/liftweb/Posting_example_code
---
You received this message because you are subscribed to the Google Groups "Lift" group.
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
--
Lift, the simply functional web framework: http://liftweb.net
Code: http://github.com/lift
Discussion: http://groups.google.com/group/liftweb
Stuck? Help us help you: https://www.assembla.com/wiki/show/liftweb/Posting_example_code
---
You received this message because you are subscribed to the Google Groups "Lift" group.
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+unsubscribe@googlegroups.com.
Antonio Salazar Cardozo
Oct 11, 2017, 10:12:15 PM10/11/17
to Lift
Yeah… Unfortunate though the situation is, I agree with Diego here. We should mark
this change for a hypothetical 4.0.
Thanks,
Antonio
Matt Farmer
Oct 11, 2017, 10:46:56 PM10/11/17
to Lift
Merp didn’t realize this connected up that way. :(
Richard
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+u...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
--
Lift, the simply functional web framework: http://liftweb.net
Code: http://github.com/lift
Discussion: http://groups.google.com/group/liftweb
Stuck? Help us help you: https://www.assembla.com/wiki/show/liftweb/Posting_example_code
---
You received this message because you are subscribed to the Google Groups "Lift" group.
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+u...@googlegroups.com.
--
--
Lift, the simply functional web framework: http://liftweb.net
Code: http://github.com/lift
Discussion: http://groups.google.com/group/liftweb
Stuck? Help us help you: https://www.assembla.com/wiki/show/liftweb/Posting_example_code
---
You received this message because you are subscribed to the Google Groups "Lift" group.
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+u...@googlegroups.com.
Joe Barnes
Oct 19, 2017, 10:44:40 AM10/19/17
to lif...@googlegroups.com
Very good points brought up here! It seemed like an innocent enough fix, but I didn't think about the fact that folks likely have already worked around the lack of csv being included, and this "fix" would break it.
I'll close the PR for now and utilize LiftRules for our application. Do we have a good way to not forget about this for Lift 4.x?
Joe
Richard
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
--
Lift, the simply functional web framework: http://liftweb.net
Code: http://github.com/lift
Discussion: http://groups.google.com/group/liftweb
Stuck? Help us help you: https://www.assembla.com/wiki/show/liftweb/Posting_example_code
---
You received this message because you are subscribed to the Google Groups "Lift" group.
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+unsubscribe@googlegroups.com.
--
--
Lift, the simply functional web framework: http://liftweb.net
Code: http://github.com/lift
Discussion: http://groups.google.com/group/liftweb
Stuck? Help us help you: https://www.assembla.com/wiki/show/liftweb/Posting_example_code
---
You received this message because you are subscribed to the Google Groups "Lift" group.
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
--
Lift, the simply functional web framework: http://liftweb.net
Code: http://github.com/lift
Discussion: http://groups.google.com/group/liftweb
Stuck? Help us help you: https://www.assembla.com/wiki/show/liftweb/Posting_example_code
---
You received this message because you are subscribed to the Google Groups "Lift" group.
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+unsubscribe@googlegroups.com.
Matt Farmer
Oct 19, 2017, 12:44:08 PM10/19/17
to lif...@googlegroups.com
There's a milestone for hypothetical 4.0. We should probably file an issue for it and add it to that milestone.
Richard
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+u...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
--
Lift, the simply functional web framework: http://liftweb.net
Code: http://github.com/lift
Discussion: http://groups.google.com/group/liftweb
Stuck? Help us help you: https://www.assembla.com/wiki/show/liftweb/Posting_example_code
---
You received this message because you are subscribed to the Google Groups "Lift" group.
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+u...@googlegroups.com.
--
--
Lift, the simply functional web framework: http://liftweb.net
Code: http://github.com/lift
Discussion: http://groups.google.com/group/liftweb
Stuck? Help us help you: https://www.assembla.com/wiki/show/liftweb/Posting_example_code
---
You received this message because you are subscribed to the Google Groups "Lift" group.
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+u...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
--
Lift, the simply functional web framework: http://liftweb.net
Code: http://github.com/lift
Discussion: http://groups.google.com/group/liftweb
Stuck? Help us help you: https://www.assembla.com/wiki/show/liftweb/Posting_example_code
---
You received this message because you are subscribed to the Google Groups "Lift" group.
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+u...@googlegroups.com.
--
--
Lift, the simply functional web framework: http://liftweb.net
Code: http://github.com/lift
Discussion: http://groups.google.com/group/liftweb
Stuck? Help us help you: https://www.assembla.com/wiki/show/liftweb/Posting_example_code
---
You received this message because you are subscribed to the Google Groups "Lift" group.
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+u...@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages