some questionable code about net.liftweb.actor

[shigang zhong]

Hi,

I found the following questionable code:

https://github.com/lift/framework/blob/master/core/actor/src/main/scala/net/liftweb/actor/LAFuture.scala#L174
def aborted_? = synchronized {satisfied}  // aborted ?

https://github.com/lift/framework/blob/master/core/actor/src/main/scala/net/liftweb/actor/LiftActor.scala#L132L136

def remove() {

val newPrev = prev

prev.next = next

next.prev = prev // newPrev ?

}

Thanks.

[shigang zhong]

https://github.com/lift/framework/blob/master/core/actor/src/main/scala/net/liftweb/actor/LiftActor.scala#L132L136

def remove() {

val newPrev = prev

prev.next = next

next.prev = prev // newPrev ?

}

It's right.  "val newPrev = prev" is redundant.

[Antonio Salazar Cardozo]

Whoops, sounds like some early code that didn't get cleaned up/hasn't

been exercised much.

Would you mind opening a PR for these two changes?

Thanks,

Antonio

[shigang zhong]

I have opened a PR for it.

Thanks.

在 2018年2月8日星期四 UTC+8上午1:31:33，Antonio Salazar Cardozo写道：