lift-omniauth issues with facebook provider
42 views
Skip to first unread message
Andrew Bucknell
Apr 1, 2017, 2:08:09 AM4/1/17
to Lift
Since March 27, my signin with facebook is broken.
It looks like the issue is that the facebookprovider in lift-omniauth is expecting an access_token query parameter in response to calls to oauth/authorize, and facebook no longer return that for this call.
I'm trying to figure out if its worth updating lift-omniauth to support a new FB login process (once I figure out what it is :) or if I just roll my own.
Thoughts? Is lift-omniauth widely used or do people use something else?
Andrew Bucknell
Apr 1, 2017, 3:00:21 AM4/1/17
to Lift
The breaking change is
[Oauth Access Token] Format - The response format of
https://www.facebook.com/v2.3/oauth/access_token returned when you exchange a code for an access_token now return valid JSON instead of being URL encoded. The new format of this response is {"access_token": {TOKEN}, "token_type":{TYPE}, "expires_in":{TIME}}. We made this update to be compliant with section 5.1 of RFC 6749.
Diego Medina
Apr 1, 2017, 5:14:42 PM4/1/17
to Lift
it would be great if you could provide a patch for it
--
--
Lift, the simply functional web framework: http://liftweb.net
Code: http://github.com/lift
Discussion: http://groups.google.com/group/liftweb
Stuck? Help us help you: https://www.assembla.com/wiki/show/liftweb/Posting_example_code
---
You received this message because you are subscribed to the Google Groups "Lift" group.
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Matt Farmer
Apr 1, 2017, 9:38:11 PM4/1/17
to Lift
I'm +1 to having a fix here. I don't use it personally at the moment, but I have some second hand knowledge that it is indeed still used. (Perhaps by folks that don't frequent the ML.)
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+u...@googlegroups.com.
--
--
--
Lift, the simply functional web framework: http://liftweb.net
Code: http://github.com/lift
Discussion: http://groups.google.com/group/liftweb
Stuck? Help us help you: https://www.assembla.com/wiki/show/liftweb/Posting_example_code
---
You received this message because you are subscribed to the Google Groups "Lift" group.
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+u...@googlegroups.com.
Andrew Bucknell
Apr 2, 2017, 4:51:58 AM4/2/17
to lif...@googlegroups.com
Thanks guys. Ive got a fix working and I'll create a pull request tomorrow.
You received this message because you are subscribed to a topic in the Google Groups "Lift" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/liftweb/ha4bBFskNyc/unsubscribe.
To unsubscribe from this group and all its topics, send an email to liftweb+u...@googlegroups.com.
Peter Petersson
Apr 2, 2017, 5:19:37 AM4/2/17
to lif...@googlegroups.com
Awesome !
Andrew Bucknell
Apr 2, 2017, 11:58:21 PM4/2/17
to Lift
Pull request created.
My day job is java dev so hopefully my code isnt too imperative :)
Riccardo Sirigu
Apr 3, 2017, 5:12:35 AM4/3/17
to Lift
We use lift-omniauth, thank you Andrew
Matt Farmer
Apr 3, 2017, 9:47:18 AM4/3/17
to Lift
TYVM Andrew. Looks like this repo is managed outside of liftmodules. Who has push access to it? :)
Diego Medina
Apr 3, 2017, 10:08:34 AM4/3/17
to Lift
Left a couple of comments (but I don't have access to merge it once it is ok). Hope the author of the module will reply to the PR
On Mon, Apr 3, 2017 at 9:47 AM, Matt Farmer <ma...@frmr.me> wrote:
TYVM Andrew. Looks like this repo is managed outside of liftmodules. Who has push access to it? :)
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
--
Lift, the simply functional web framework: http://liftweb.net
Code: http://github.com/lift
Discussion: http://groups.google.com/group/liftweb
Stuck? Help us help you: https://www.assembla.com/wiki/show/liftweb/Posting_example_code
---
You received this message because you are subscribed to the Google Groups "Lift" group.
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+unsubscribe@googlegroups.com.
Riccardo Sirigu
Apr 4, 2017, 5:24:41 AM4/4/17
to Lift
When will the maven repository be updated?
Il giorno lunedì 3 aprile 2017 16:08:34 UTC+2, fmpwizard ha scritto:
Left a couple of comments (but I don't have access to merge it once it is ok). Hope the author of the module will reply to the PR
On Mon, Apr 3, 2017 at 9:47 AM, Matt Farmer <ma...@frmr.me> wrote:
TYVM Andrew. Looks like this repo is managed outside of liftmodules. Who has push access to it? :)
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+u...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
--
Lift, the simply functional web framework: http://liftweb.net
Code: http://github.com/lift
Discussion: http://groups.google.com/group/liftweb
Stuck? Help us help you: https://www.assembla.com/wiki/show/liftweb/Posting_example_code
---
You received this message because you are subscribed to the Google Groups "Lift" group.
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+u...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
Matt Farmer
Apr 4, 2017, 8:08:31 AM4/4/17
to Lift
The short answer is we don't know. Looks like this module is maintained by an individual contributor, not by the Lift team. We'll probably shoot him a note if he hasn't noticed the fix in a few days and see if we can get the ball rolling.
Diego Medina
Apr 4, 2017, 10:11:08 AM4/4/17
to Lift
The PR is now merged, I'm now re-provisioning the cloudbees service we use for the modules to see if this module is there, and I'll run a build. I'll post here in a few minutes with more information.
Thanks
Diego
On Tue, Apr 4, 2017 at 8:08 AM, Matt Farmer <ma...@frmr.me> wrote:
The short answer is we don't know. Looks like this module is maintained by an individual contributor, not by the Lift team. We'll probably shoot him a note if he hasn't noticed the fix in a few days and see if we can get the ball rolling.
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
--
Lift, the simply functional web framework: http://liftweb.net
Code: http://github.com/lift
Discussion: http://groups.google.com/group/liftweb
Stuck? Help us help you: https://www.assembla.com/wiki/show/liftweb/Posting_example_code
---
You received this message because you are subscribed to the Google Groups "Lift" group.
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+unsubscribe@googlegroups.com.
Diego Medina
Apr 4, 2017, 10:38:36 AM4/4/17
to Lift
provisioning the server failed, I just submitted a ticket with them to get more info ...
Richard Dallaway
Apr 4, 2017, 11:07:26 AM4/4/17
to Lift
:-(. Happy to Travis-ifty that build.
On Tue, 4 Apr 2017 at 15:38 Diego Medina <di...@fmpwizard.com> wrote:
provisioning the server failed, I just submitted a ticket with them to get more info ...
On Tue, Apr 4, 2017 at 10:11 AM, Diego Medina <di...@fmpwizard.com> wrote:
The PR is now merged, I'm now re-provisioning the cloudbees service we use for the modules to see if this module is there, and I'll run a build. I'll post here in a few minutes with more information.ThanksDiego
On Tue, Apr 4, 2017 at 8:08 AM, Matt Farmer <ma...@frmr.me> wrote:
The short answer is we don't know. Looks like this module is maintained by an individual contributor, not by the Lift team. We'll probably shoot him a note if he hasn't noticed the fix in a few days and see if we can get the ball rolling.
--
Diego Medina
Apr 4, 2017, 11:32:35 AM4/4/17
to Lift
Travis has been working well for the main project, if you or anyone has time for the migration, I'm +1
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
--
Lift, the simply functional web framework: http://liftweb.net
Code: http://github.com/lift
Discussion: http://groups.google.com/group/liftweb
Stuck? Help us help you: https://www.assembla.com/wiki/show/liftweb/Posting_example_code
---
You received this message because you are subscribed to the Google Groups "Lift" group.
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+unsubscribe@googlegroups.com.
--
--
--
Lift, the simply functional web framework: http://liftweb.net
Code: http://github.com/lift
Discussion: http://groups.google.com/group/liftweb
Stuck? Help us help you: https://www.assembla.com/wiki/show/liftweb/Posting_example_code
---
You received this message because you are subscribed to the Google Groups "Lift" group.
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
--
Lift, the simply functional web framework: http://liftweb.net
Code: http://github.com/lift
Discussion: http://groups.google.com/group/liftweb
Stuck? Help us help you: https://www.assembla.com/wiki/show/liftweb/Posting_example_code
---
You received this message because you are subscribed to the Google Groups "Lift" group.
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+unsubscribe@googlegroups.com.
Diego Medina
Apr 4, 2017, 9:55:31 PM4/4/17
to Lift
so I got a reply from their support, to put it politely, I would say it's not what I expected:
==========
Owen Wood (CloudBees Support)
Apr 4, 7:08 PM EDT
Hi Diego,
Unfortunately this instance was de-provisioned due to inactivity.
Due to the fact that it was a FOSS account, and we no longer offer this service, the instance was removed and is unable to be recovered.
Apologies for the inconvenience.
Best regards,
Owen Wood
CloudBees, Inc
===========
Matt Farmer
Apr 4, 2017, 10:11:27 PM4/4/17
to Lift
All I can say is "cloudbees 😐"
Riccardo Sirigu
Apr 6, 2017, 4:44:45 AM4/6/17
to Lift
Im +1
Richard Dallaway
Apr 11, 2017, 12:33:49 PM4/11/17
to Lift
The omniauth module build is currently failing for Scala 2.9. Does anyone use the module with that version of Scala? I’m asking if we can drop 2.9 for this module at https://github.com/ghostm/lift-omniauth/issues/51
Reply all
Reply to author
Forward
0 new messages