Lift 3.2.0-M2 Last Call

22 views
Skip to first unread message

Matt Farmer

unread,
Sep 12, 2017, 10:26:37 PM9/12/17
to Lift
Hey everyone,

Just wanted to send out a friendly reminder that the cut off to make 3.2.0-M2 is Friday, September 15th. We'll likely cut the release sometime on Friday or this weekend.

We've got quite a few easy open issues on the milestone that we would appreciate help with if you have some time to spare. =)

Cheers,
Matt

Andreas Joseph Krogh

unread,
Sep 13, 2017, 3:00:48 AM9/13/17
to lif...@googlegroups.com
Hi.
 
I've always been annoied that Exceptions in Schedule.schedule() are not logged with stack-traces.
I maintain this code i a separate branch we use:
 
@@ -151,7 +151,7 @@ sealed trait Schedule extends Loggable {
          try {
            f.apply()
          } catch {
-            case e: Exception => logger.error(e)
+            case e: Exception => logger.error(e.getMessage, e)
          }
        }
      }
@@ -162,7 +162,7 @@ sealed trait Schedule extends Loggable {
            Schedule.this.restart
            pool.execute(r)
          } catch {
-            case e: Exception => logger.error(e)
+            case e: Exception => logger.error(e.getMessage, e)
          }
        }
      }


 
What do you people think, whould you welcome a PR for this?
 
--
Andreas Joseph Krogh
CTO / Partner - Visena AS
Mobile: +47 909 56 963
 

Matt Farmer

unread,
Sep 13, 2017, 8:39:53 AM9/13/17
to lif...@googlegroups.com
Absolutely!
--
--
Lift, the simply functional web framework: http://liftweb.net
Code: http://github.com/lift
Discussion: http://groups.google.com/group/liftweb
Stuck? Help us help you: https://www.assembla.com/wiki/show/liftweb/Posting_example_code

---
You received this message because you are subscribed to the Google Groups "Lift" group.
To unsubscribe from this group and stop receiving emails from it, send an email to liftweb+u...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Antonio Salazar Cardozo

unread,
Sep 13, 2017, 11:52:16 AM9/13/17
to Lift
I would basically fall over with delight. So please don't open the PR until I'm seated on
the floor ;)
Thanks,
Antonio

Andreas Joseph Krogh

unread,
Sep 15, 2017, 6:53:54 AM9/15/17
to lif...@googlegroups.com
Here:
 
I included the exception some other places where it was missing too.
 
--
Andreas Joseph Krogh
CTO / Partner - Visena AS
Mobile: +47 909 56 963
 
--

Matt Farmer

unread,
Sep 15, 2017, 9:16:39 AM9/15/17
to lif...@googlegroups.com
This looks wonderful. Left you some code review on it.
Reply all
Reply to author
Forward
0 new messages