Kurento-Utils, setRemoteVideo no longer working in Safari 12.1 after Mojave update to 10.14.4

[Neil Young]

https://github.com/Kurento/kurento-utils-js/blob/3304407626caa4c26ef1e9d92a79c9684f84725c/lib/WebRtcPeer.js#L424-L434

Trace is "Remote stream: undefined"

I noticed the difference in behaviour, since the Developer menu doesn't contain the menu item "WebRTC/Enable older versions" (maybe other wording in English).

This was necessary to make KurentuUtils run at all in Safari 12. It's gone, KurentoUtils gone too :)

Confirmations?

[Neil Young]

My proposal (and my local solution) would be to dry out the deprecated pc.getRemoteStream()[0] and add a handler for the onTrack callback instead:

// pc.onaddstream = options.onaddstream

pc.ontrack = options.ontrack || function (event) {

logger.debug("Remote track(s) received")

event.streams[0].getTracks().forEach(track => {

logger.debug("Remote track", track)

})

if (remoteVideo) {

if (remoteVideo.srcObject != event.streams[0]) {

remoteVideo.srcObject = event.streams[0]

logger.debug("Remote stream assigned to remote video display")

remoteVideo.onloadedmetadata = (event) => {

logger.debug("Remote video play")

remoteVideo.play().then(() => { logger.debug("Remote video playing") }).catch((err) => { logger.error("Error while trying to play remote video:", err) })

}

}

}

}

function setRemoteVideo() {

logger.debug("setRemoteVideo deprecated")

// if (remoteVideo) {

// remoteVideo.pause()

// var stream = pc.getRemoteStreams()[0]

// remoteVideo.srcObject = stream

// logger.debug('Remote stream:', stream)

// remoteVideo.load()

// }

}

This makes it work again in all recent browsers. Not sure if it is worth a PR

[Neil Young]

The pc.ontrack would probably have to be changed to avoid problems with mixed usage of old-style functions and arrow-functions:

// pc.onaddstream = options.onaddstream

pc.ontrack = options.ontrack || function (event) {

logger.debug("Remote track(s) received")

event.streams[0].getTracks().forEach(function(track) {

logger.debug("Remote track", track)

})

if (remoteVideo) {

if (remoteVideo.srcObject != event.streams[0]) {

remoteVideo.srcObject = event.streams[0]

logger.debug("Remote stream assigned to remote video display")

remoteVideo.onloadedmetadata = function () {

logger.debug("Remote video play")

remoteVideo.play().then(function() { logger.debug("Remote video playing") }).catch(function(err) { logger.error("Error while trying to play remote video:", err) })

}

}

}

}

[solom...@gmail.com]

My 23 days old PR: https://github.com/Kurento/kurento-utils-js/pull/28 :))

[Micael Gallego]

Tha ks

--
You received this message because you are subscribed to the Google Groups "kurento" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kurento+u...@googlegroups.com.
To post to this group, send email to kur...@googlegroups.com.
Visit this group at https://groups.google.com/group/kurento.
To view this discussion on the web visit https://groups.google.com/d/msgid/kurento/6274e603-35d1-43f2-97d9-5ac554bcac97%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Neil Young]

When will it be taken over?

Tha ks

To unsubscribe from this group and stop receiving emails from it, send an email to kur...@googlegroups.com.

[Micael Gallego]

Todos los tests e2e de Kurento usan KurentoUtils under the hood. Pero no sé si se ejecutan en los browsers afectados o no.

Me parece bien ponerlo en la 6.11, pero avisa please del planning para que la gente nos vea que respondemos.

Un saludo

To unsubscribe from this group and stop receiving emails from it, send an email to kurento+u...@googlegroups.com.

To post to this group, send email to kur...@googlegroups.com.
Visit this group at https://groups.google.com/group/kurento.

To view this discussion on the web visit https://groups.google.com/d/msgid/kurento/13bc6a64-1969-4588-a54a-2a8f23cd4874%40googlegroups.com.

[Neil Young]

Ehem...??

[Micael Gallego]

Sorry ;)

We are working on it. We are going to publish 6.10 version in a few days and we will accept the PR for the next version to be able to test it.

--
You received this message because you are subscribed to the Google Groups "kurento" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kurento+u...@googlegroups.com.
To post to this group, send email to kur...@googlegroups.com.
Visit this group at https://groups.google.com/group/kurento.

To view this discussion on the web visit https://groups.google.com/d/msgid/kurento/6428EC66-E1F8-44B2-96EE-E08A9694D0BB%40googlemail.com.

[Neil Young]

I can confirm: Your PR is working in all browsers. And it is more generic than mine.

Thanks 

[solom...@gmail.com]

glad to help :)

[Carlos]

This PR is already merged, but the line "pc.onaddstream = options.onaddstream;" is still in the code. As per what I understand, this line is not needed anymore, right? Right now it's deprecated and it throws a warning in the console.

Thanks