First time to Make Pull Requests

[fros...@koonsoft.dk]

I have tried to follow https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests

I have a proposal for correction to FileLayout.php.
When I was through, the process ended with the fact that "Pull Requests" were now being done against staging.

So, according to the description, I have to be patient, whether the correction is accepted.

It's OK, but I can not see my suggestion anywhere, have I done anything wrong?

This in a small attempt to give something back to Joomla
Yours sincerely
Karsten F.

[Niels Braczek]

Hi Karsten,

> It's OK, but I can not see my suggestion anywhere, have I done anything wrong?

I can't see anything either. What is your GitHub username?

> This in a small attempt to give something back to Joomla

Thank you!

Regards,
Niels

--
| New Stars on the Horizon: GreenCape · nibralab · laJoom |
| http://www.bsds.de · BSDS Braczek Software- und DatenSysteme |
| Webdesign · Webhosting · e-Commerce · Joomla! Content Management |
------------------------------------------------------------------

[fros...@koonsoft.dk]

KarstenFrostholm

[fros...@koonsoft.dk]

Den tirsdag den 26. december 2017 kl. 12.51.04 UTC+1 skrev fros...@koonsoft.dk:

From deprecated.php
This "Functions that are deleted when switching to version 4.0". Repeated many times.

Joomla\CMS\Layout\FileLayout::setLayout() is deprecated, use FileLayout::setLayoutId() instead.
Joomla\CMS\Layout\FileLayout::refreshIncludePaths() is deprecated, use FileLayout::clearIncludePaths() instead.

Pull Request for Issue # .
Summary of Changes

Now using the recommended methods
Testing Instructions

With a fresh 3.8.3 enabled log deprecated API logging
switch to site once
check log in administrator/logs/deprecated.php
Install patch

switch to site once
check log in administrator/logs/deprecated.php
Expected result

No log entry from this file
Actual result

2017-12-26T08:15:40+00:00 WARNING ::1 deprecated Joomla\CMS\Layout\FileLayout::setLayout() is deprecated, use FileLayout::setLayoutId() instead.
2017-12-26T08:15:40+00:00 WARNING ::1 deprecated Joomla\CMS\Layout\FileLayout::refreshIncludePaths() is deprecated, use FileLayout::clearIncludePaths() instead.
2017-12-26T08:15:40+00:00 WARNING ::1 deprecated Joomla\CMS\Layout\FileLayout::refreshIncludePaths() is deprecated, use FileLayout::clearIncludePaths() instead.
Documentation Changes Required

No

...........

KarstenFrostholm merged commit 7692228 into staging 5 hours ago

[fros...@koonsoft.dk]

Den tirsdag den 26. december 2017 kl. 12.51.04 UTC+1 skrev fros...@koonsoft.dk:

Update FileLayout.php

From deprecated.php
This "Functions that are deleted when switching to version 4.0". Repeated many times.

Joomla\CMS\Layout\FileLayout::setLayout() is deprecated, use FileLayout::setLayoutId() instead.
Joomla\CMS\Layout\FileLayout::refreshIncludePaths() is deprecated, use FileLayout::clearIncludePaths() instead.

staging (#1)

commit fa3a96630c8ccebd1f81d5f04c741c2c21a93951 @KarstenFrostholm

KarstenFrostholm committed 6 hours ago
6 libraries/src/Layout/FileLayout.php
@@ -77,7 +77,7 @@ public function __construct($layoutId, $basePath = null, $options = null)
$this->setOptions($options);

// Main properties
- $this->setLayout($layoutId);
+ $this->setLayoutId($layoutId);
$this->basePath = $basePath;

// Init Enviroment
@@ -470,7 +470,7 @@ public function setComponent($option)
$this->options->set('component', $component);

// Refresh include paths
- $this->refreshIncludePaths();
+ $this->clearIncludePaths();
}

/**
@@ -505,7 +505,7 @@ public function setClient($client)
$this->options->set('client', $client);

// Refresh include paths
- $this->refreshIncludePaths();
+ $this->clearIncludePaths();
}

/**

[Niels Braczek]

Hi Karsten,

> KarstenFrostholm

Ok.

- Go to your repo (https://github.com/KarstenFrostholm)
- Select the branch containing the patch (KarstenFrostholm-patch-1)
- Click on the [New pull request] button
- Fill in the sections of the pull request template
- Click on the [Create pull request] button

That should do it.

[Fros...@koonsoft.dk]

Den tirsdag den 26. december 2017 kl. 12.51.04 UTC+1 skrev fros...@koonsoft.dk:

Hi Niels
Thanks for the help, so let's see if it can be used.
There are some kind of corrections that I will pursue
Yours sincerely
Karsten F